-
Notifications
You must be signed in to change notification settings - Fork 305
🍒 9032 - Fix ArrayIndexOutOfBoundsException in PercentEscaper #9050
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(cherry picked from commit 7f6f769)
bric3
approved these changes
Jun 27, 2025
sarahchen6
approved these changes
Jun 27, 2025
amarziali
approved these changes
Jun 27, 2025
BenchmarksStartupParameters
See matching parameters
SummaryFound 1 performance improvements and 5 performance regressions! Performance is the same for 35 metrics, 12 unstable metrics.
Startup time reports for insecure-bankgantt
title insecure-bank - global startup overhead: candidate=1.51.0-SNAPSHOT~6ea9bb2bee, baseline=1.51.0-SNAPSHOT~640fc88be4
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (996.47 ms) : 0, 996470
Total [baseline] (8.559 s) : 0, 8558919
Agent [candidate] (1.026 s) : 0, 1025646
Total [candidate] (8.545 s) : 0, 8545235
section iast
Agent [baseline] (1.134 s) : 0, 1133542
Total [baseline] (9.304 s) : 0, 9304225
Agent [candidate] (1.16 s) : 0, 1160429
Total [candidate] (9.243 s) : 0, 9242555
gantt
title insecure-bank - break down per module: candidate=1.51.0-SNAPSHOT~6ea9bb2bee, baseline=1.51.0-SNAPSHOT~640fc88be4
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.703 ms) : 0, 687703
BytebuddyAgent [candidate] (685.573 ms) : 0, 685573
GlobalTracer [baseline] (242.755 ms) : 0, 242755
GlobalTracer [candidate] (242.189 ms) : 0, 242189
AppSec [baseline] (30.283 ms) : 0, 30283
AppSec [candidate] (58.194 ms) : 0, 58194
Debugger [baseline] (6.031 ms) : 0, 6031
Debugger [candidate] (7.663 ms) : 0, 7663
Remote Config [baseline] (671.839 µs) : 0, 672
Remote Config [candidate] (655.584 µs) : 0, 656
Telemetry [baseline] (8.255 ms) : 0, 8255
Telemetry [candidate] (10.486 ms) : 0, 10486
section iast
BytebuddyAgent [baseline] (809.684 ms) : 0, 809684
BytebuddyAgent [candidate] (812.371 ms) : 0, 812371
GlobalTracer [baseline] (233.232 ms) : 0, 233232
GlobalTracer [candidate] (233.233 ms) : 0, 233233
IAST [baseline] (27.83 ms) : 0, 27830
IAST [candidate] (27.831 ms) : 0, 27831
AppSec [baseline] (27.688 ms) : 0, 27688
AppSec [candidate] (51.43 ms) : 0, 51430
Debugger [baseline] (5.808 ms) : 0, 5808
Debugger [candidate] (5.963 ms) : 0, 5963
Remote Config [baseline] (570.022 µs) : 0, 570
Remote Config [candidate] (602.191 µs) : 0, 602
Telemetry [baseline] (7.962 ms) : 0, 7962
Telemetry [candidate] (8.014 ms) : 0, 8014
Startup time reports for petclinicgantt
title petclinic - global startup overhead: candidate=1.51.0-SNAPSHOT~6ea9bb2bee, baseline=1.51.0-SNAPSHOT~640fc88be4
dateFormat X
axisFormat %s
section tracing
Agent [baseline] (997.567 ms) : 0, 997567
Total [baseline] (10.574 s) : 0, 10574374
Agent [candidate] (1.026 s) : 0, 1025783
Total [candidate] (10.601 s) : 0, 10600977
section appsec
Agent [baseline] (1.176 s) : 0, 1176062
Total [baseline] (10.746 s) : 0, 10745908
Agent [candidate] (1.175 s) : 0, 1174920
Total [candidate] (10.688 s) : 0, 10688147
section iast
Agent [baseline] (1.134 s) : 0, 1134425
Total [baseline] (10.815 s) : 0, 10814649
Agent [candidate] (1.151 s) : 0, 1151102
Total [candidate] (10.907 s) : 0, 10907059
section profiling
Agent [baseline] (1.244 s) : 0, 1244322
Total [baseline] (10.965 s) : 0, 10964925
Agent [candidate] (1.272 s) : 0, 1271843
Total [candidate] (10.94 s) : 0, 10939958
gantt
title petclinic - break down per module: candidate=1.51.0-SNAPSHOT~6ea9bb2bee, baseline=1.51.0-SNAPSHOT~640fc88be4
dateFormat X
axisFormat %s
section tracing
BytebuddyAgent [baseline] (687.724 ms) : 0, 687724
BytebuddyAgent [candidate] (685.846 ms) : 0, 685846
GlobalTracer [baseline] (243.246 ms) : 0, 243246
GlobalTracer [candidate] (242.412 ms) : 0, 242412
AppSec [baseline] (30.567 ms) : 0, 30567
AppSec [candidate] (57.339 ms) : 0, 57339
Debugger [baseline] (6.075 ms) : 0, 6075
Debugger [candidate] (8.55 ms) : 0, 8550
Remote Config [baseline] (685.339 µs) : 0, 685
Remote Config [candidate] (681.068 µs) : 0, 681
Telemetry [baseline] (8.305 ms) : 0, 8305
Telemetry [candidate] (10.031 ms) : 0, 10031
section appsec
BytebuddyAgent [baseline] (710.466 ms) : 0, 710466
BytebuddyAgent [candidate] (707.887 ms) : 0, 707887
GlobalTracer [baseline] (236.592 ms) : 0, 236592
GlobalTracer [candidate] (234.93 ms) : 0, 234930
IAST [baseline] (21.977 ms) : 0, 21977
IAST [candidate] (21.818 ms) : 0, 21818
AppSec [baseline] (171.689 ms) : 0, 171689
AppSec [candidate] (175.809 ms) : 0, 175809
Debugger [baseline] (5.803 ms) : 0, 5803
Debugger [candidate] (5.898 ms) : 0, 5898
Remote Config [baseline] (612.116 µs) : 0, 612
Remote Config [candidate] (617.772 µs) : 0, 618
Telemetry [baseline] (8.124 ms) : 0, 8124
Telemetry [candidate] (7.183 ms) : 0, 7183
section iast
BytebuddyAgent [baseline] (810.107 ms) : 0, 810107
BytebuddyAgent [candidate] (805.388 ms) : 0, 805388
GlobalTracer [baseline] (233.266 ms) : 0, 233266
GlobalTracer [candidate] (231.845 ms) : 0, 231845
IAST [baseline] (28.72 ms) : 0, 28720
IAST [candidate] (27.272 ms) : 0, 27272
AppSec [baseline] (27.088 ms) : 0, 27088
AppSec [candidate] (51.25 ms) : 0, 51250
Debugger [baseline] (5.82 ms) : 0, 5820
Debugger [candidate] (5.934 ms) : 0, 5934
Remote Config [baseline] (573.274 µs) : 0, 573
Remote Config [candidate] (606.174 µs) : 0, 606
Telemetry [baseline] (7.94 ms) : 0, 7940
Telemetry [candidate] (8.015 ms) : 0, 8015
section profiling
BytebuddyAgent [baseline] (678.563 ms) : 0, 678563
BytebuddyAgent [candidate] (678.63 ms) : 0, 678630
GlobalTracer [baseline] (360.577 ms) : 0, 360577
GlobalTracer [candidate] (361.585 ms) : 0, 361585
AppSec [baseline] (31.519 ms) : 0, 31519
AppSec [candidate] (61.756 ms) : 0, 61756
Debugger [baseline] (11.547 ms) : 0, 11547
Debugger [candidate] (6.126 ms) : 0, 6126
Remote Config [baseline] (661.139 µs) : 0, 661
Remote Config [candidate] (705.493 µs) : 0, 705
Telemetry [baseline] (9.581 ms) : 0, 9581
Telemetry [candidate] (8.145 ms) : 0, 8145
ProfilingAgent [baseline] (103.057 ms) : 0, 103057
ProfilingAgent [candidate] (105.928 ms) : 0, 105928
Profiling [baseline] (103.082 ms) : 0, 103082
Profiling [candidate] (105.953 ms) : 0, 105953
LoadDacapoParameters
See matching parameters
SummaryFound 0 performance improvements and 0 performance regressions! Performance is the same for 12 metrics, 0 unstable metrics. Execution time for biojavagantt
title biojava - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~6ea9bb2bee, baseline=1.51.0-SNAPSHOT~640fc88be4
dateFormat X
axisFormat %s
section baseline
no_agent (15.543 s) : 15543000, 15543000
. : milestone, 15543000,
appsec (14.703 s) : 14703000, 14703000
. : milestone, 14703000,
iast (18.043 s) : 18043000, 18043000
. : milestone, 18043000,
iast_GLOBAL (17.925 s) : 17925000, 17925000
. : milestone, 17925000,
profiling (15.778 s) : 15778000, 15778000
. : milestone, 15778000,
tracing (14.862 s) : 14862000, 14862000
. : milestone, 14862000,
section candidate
no_agent (15.323 s) : 15323000, 15323000
. : milestone, 15323000,
appsec (14.887 s) : 14887000, 14887000
. : milestone, 14887000,
iast (18.783 s) : 18783000, 18783000
. : milestone, 18783000,
iast_GLOBAL (18.035 s) : 18035000, 18035000
. : milestone, 18035000,
profiling (15.887 s) : 15887000, 15887000
. : milestone, 15887000,
tracing (14.875 s) : 14875000, 14875000
. : milestone, 14875000,
Execution time for tomcatgantt
title tomcat - execution time [CI 0.99] : candidate=1.51.0-SNAPSHOT~6ea9bb2bee, baseline=1.51.0-SNAPSHOT~640fc88be4
dateFormat X
axisFormat %s
section baseline
no_agent (1.472 ms) : 1460, 1483
. : milestone, 1472,
appsec (2.398 ms) : 2350, 2446
. : milestone, 2398,
iast (2.183 ms) : 2122, 2243
. : milestone, 2183,
iast_GLOBAL (2.217 ms) : 2155, 2278
. : milestone, 2217,
profiling (2.01 ms) : 1962, 2058
. : milestone, 2010,
tracing (1.993 ms) : 1946, 2040
. : milestone, 1993,
section candidate
no_agent (1.477 ms) : 1466, 1489
. : milestone, 1477,
appsec (2.388 ms) : 2340, 2436
. : milestone, 2388,
iast (2.177 ms) : 2116, 2237
. : milestone, 2177,
iast_GLOBAL (2.213 ms) : 2152, 2274
. : milestone, 2213,
profiling (2.04 ms) : 1990, 2090
. : milestone, 2040,
tracing (1.994 ms) : 1947, 2041
. : milestone, 1994,
|
I've bypassed CI checks and merged to expedite the release process We will wait for all tests and checks prior to releasing v1.50.1 |
svc-squareup-copybara
pushed a commit
to cashapp/misk
that referenced
this pull request
Jun 30, 2025
| Package | Type | Package file | Manager | Update | Change | |---|---|---|---|---|---| | [com.google.cloud:google-cloud-spanner](https://github.com/googleapis/java-spanner) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `6.95.1` -> `6.96.0` | | [com.google.cloud:google-cloud-datastore](https://github.com/googleapis/java-datastore) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `2.29.2` -> `2.30.0` | | [com.squareup.okio:okio-fakefilesystem](https://github.com/square/okio) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `3.13.0` -> `3.14.0` | | [com.squareup.okio:okio](https://github.com/square/okio) | dependencies | misk/gradle/libs.versions.toml | gradle | minor | `3.13.0` -> `3.14.0` | | [com.datadoghq:dd-trace-api](https://github.com/datadog/dd-trace-java) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `1.50.0` -> `1.50.1` | | [software.amazon.awssdk:sdk-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.71` -> `2.31.73` | | [software.amazon.awssdk:sqs](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.71` -> `2.31.73` | | [software.amazon.awssdk:dynamodb-enhanced](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.71` -> `2.31.73` | | [software.amazon.awssdk:dynamodb](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.71` -> `2.31.73` | | [software.amazon.awssdk:aws-core](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.71` -> `2.31.73` | | [software.amazon.awssdk:bom](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.71` -> `2.31.73` | | [software.amazon.awssdk:auth](https://aws.amazon.com/sdkforjava) | dependencies | misk/gradle/libs.versions.toml | gradle | patch | `2.31.71` -> `2.31.73` | --- ### Release Notes <details> <summary>googleapis/java-spanner (com.google.cloud:google-cloud-spanner)</summary> ### [`v6.96.0`](https://github.com/googleapis/java-spanner/blob/HEAD/CHANGELOG.md#6960-2025-06-27) ##### Features - Allow JDBC to configure directpath for connection ([#​3929](googleapis/java-spanner#3929)) ([d754f1f](googleapis/java-spanner@d754f1f)) - Support getOrNull and getOrDefault in Struct ([#​3914](googleapis/java-spanner#3914)) ([1dc5a3e](googleapis/java-spanner@1dc5a3e)) - Use multiplexed sessions for read-only transactions ([#​3917](googleapis/java-spanner#3917)) ([37fdc27](googleapis/java-spanner@37fdc27)) ##### Bug Fixes - Allow zero durations to be set for connections ([#​3916](googleapis/java-spanner#3916)) ([43ea4fa](googleapis/java-spanner@43ea4fa)) ##### Documentation - Add snippet for Repeatable Read configuration at client and transaction ([#​3908](googleapis/java-spanner#3908)) ([ff3d212](googleapis/java-spanner@ff3d212)) - Update SpannerSample.java to align with best practices ([#​3625](googleapis/java-spanner#3625)) ([7bfc62d](googleapis/java-spanner@7bfc62d)) </details> <details> <summary>googleapis/java-datastore (com.google.cloud:google-cloud-datastore)</summary> ### [`v2.30.0`](https://github.com/googleapis/java-datastore/blob/HEAD/CHANGELOG.md#2300-2025-06-26) ##### Features - Enable grpc configurator for client-side tracing ([#​1886](googleapis/java-datastore#1886)) ([97004c8](googleapis/java-datastore@97004c8)) ##### Dependencies - Update dependency com.google.cloud:gapic-libraries-bom to v1.60.0 ([#​1799](googleapis/java-datastore#1799)) ([bf2a33c](googleapis/java-datastore@bf2a33c)) - Update dependency com.google.cloud:sdk-platform-java-config to v3.50.0 ([#​1897](googleapis/java-datastore#1897)) ([a8d99cd](googleapis/java-datastore@a8d99cd)) - Update googleapis/sdk-platform-java action to v2.59.1 ([#​1880](googleapis/java-datastore#1880)) ([4fb9929](googleapis/java-datastore@4fb9929)) - Update googleapis/sdk-platform-java action to v2.60.0 ([#​1898](googleapis/java-datastore#1898)) ([0921f86](googleapis/java-datastore@0921f86)) </details> <details> <summary>square/okio (com.squareup.okio:okio-fakefilesystem)</summary> ### [`v3.14.0`](https://github.com/square/okio/blob/HEAD/CHANGELOG.md#Version-3140) *2025-06-28* - Upgrade: \[kotlinx-datetime 0.7.0]\[datetime\_0\_7\_0]. This impacts the `okio-fakefilesystem` artifact only. This is a binary-incompatible backwards-incompatible change that cannot co-exist with previous releases of `okio-fakefilesystem`! If you observe a `NoSuchMethodError` calling `FakeFileSystem.init`, update the calling code to this release (or newer) and recompile. We don't like imposing backwards-incompatible changes like this on you and do so regretfully. </details> <details> <summary>datadog/dd-trace-java (com.datadoghq:dd-trace-api)</summary> ### [`v1.50.1`](https://github.com/DataDog/dd-trace-java/releases/tag/v1.50.1): 1.50.1 ### Components #### Build & Tooling - ✨ Migrate publishing to Maven Central Portal ([#​9054](DataDog/dd-trace-java#9054) - [@​sarahchen6](https://github.com/sarahchen6)) #### Trace context propagation - 🐛 Drop Baggage when `TracePropagationBehaviorExtract=IGNORE` ([#​9052](DataDog/dd-trace-java#9052) - [@​mhlidd](https://github.com/mhlidd)) #### Tracer public API - 🐛 Fix ArrayIndexOutOfBoundsException in PercentEscaper ([#​9050](DataDog/dd-trace-java#9050) - [@​mhlidd](https://github.com/mhlidd)) ### Instrumentations #### Akka instrumentation - 🐛 Fix NPE in akka-http and pekko-http integrations ([#​9049](DataDog/dd-trace-java#9049) - [@​mcculls](https://github.com/mcculls)) </details> --- ### Configuration 📅 **Schedule**: Branch creation - "after 6pm every weekday,before 2am every weekday" in timezone Australia/Melbourne, Automerge - At any time (no schedule defined). 🚦 **Automerge**: Enabled. ♻ **Rebasing**: Never, or you tick the rebase/retry checkbox. 👻 **Immortal**: This PR will be recreated if closed unmerged. Get [config help](https://github.com/renovatebot/renovate/discussions) if that's undesired. --- - [ ] <!-- rebase-check -->If you want to rebase/retry this PR, check this box --- This PR has been generated by [Renovate Bot](https://github.com/renovatebot/renovate). GitOrigin-RevId: e80867de3af2534eca79fe17a33f5c76801bcd6a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Backport #9032 to release/v1.50.x