docs: Update SpannerSample.java to align with best practices (#3625)

adhiggs · sakthivelmanii · web-flow · commit 7bfc62d3d9e5 · 2025-06-17T12:45:01.000+05:30
* Update SpannerSample.java

Encapsulates both statements in a try-with-resources statement

* Update SpannerSample.java

* Update SpannerSample.java

Fix spacing linter errors

* Update SpannerSample.java

Clear Linter errors for indent

---------

Co-authored-by: Sakthivel Subramanian &lt;179120858+sakthivelmanii@users.noreply.github.com&gt;
diff --git a/samples/snippets/src/main/java/com/example/spanner/SpannerSample.java b/samples/snippets/src/main/java/com/example/spanner/SpannerSample.java
@@ -679,24 +679,25 @@ static void readOnlyTransaction(DatabaseClient dbClient) {
     // ReadOnlyTransaction must be closed by calling close() on it to release resources held by it.
     // We use a try-with-resource block to automatically do so.
     try (ReadOnlyTransaction transaction = dbClient.readOnlyTransaction()) {
-      ResultSet queryResultSet =
+      try (ResultSet queryResultSet =
           transaction.executeQuery(
-              Statement.of("SELECT SingerId, AlbumId, AlbumTitle FROM Albums"));
-      while (queryResultSet.next()) {
-        System.out.printf(
-            "%d %d %s\n",
-            queryResultSet.getLong(0), queryResultSet.getLong(1), queryResultSet.getString(2));
-      }
+              Statement.of("SELECT SingerId, AlbumId, AlbumTitle FROM Albums"))) {
+        while (queryResultSet.next()) {
+          System.out.printf(
+              "%d %d %s\n",
+              queryResultSet.getLong(0), queryResultSet.getLong(1), queryResultSet.getString(2));
+        }
+      } // queryResultSet.close() is automatically called here
       try (ResultSet readResultSet =
           transaction.read(
-              "Albums", KeySet.all(), Arrays.asList("SingerId", "AlbumId", "AlbumTitle"))) {
+            "Albums", KeySet.all(), Arrays.asList("SingerId", "AlbumId", "AlbumTitle"))) {
         while (readResultSet.next()) {
           System.out.printf(
               "%d %d %s\n",
               readResultSet.getLong(0), readResultSet.getLong(1), readResultSet.getString(2));
         }
-      }
-    }
+      } // readResultSet.close() is automatically called here
+    } // transaction.close() is automatically called here
   }
   // [END spanner_read_only_transaction]
 
