ICU-23155 Fix buffer overflow in SSearchTest::offsetTest() by gvictor · Pull Request #3546 · unicode-org/icu · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

ICU-23155 Fix buffer overflow in SSearchTest::offsetTest() #3546

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

ICU-23155 Fix buffer overflow in SSearchTest::offsetTest() #3546

wants to merge 1 commit into from
+31 −22

Conversation

gvictor
Copy link
Collaborator

@gvictor gvictor commented Jul 3, 2025 •
edited
Loading

https://unicode-org.atlassian.net/browse/ICU-23155

Use std::string instead.

Root cause analysis:
In printOffsets, while the pointer s is advanced, the remaining size n remains unchanged to be a constant 4096, and snprintf falsely thinks the buffer has 4096 bytes left.

Checklist

  • Required: Issue filed: ICU-23155
  • Required: The PR title must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Required: Each commit message must be prefixed with a JIRA Issue number. Example: "ICU-1234 Fix xyz"
  • Issue accepted (done by Technical Committee after discussion)
  • Tests included, if applicable
  • API docs and/or User Guide docs changed or added, if applicable

@gvictor
ICU-23155 Fix buffer overflow in SSearchTest::offsetTest()
d3f3f03 
https://unicode-org.atlassian.net/browse/ICU-23155

Use std::string instead.

Root cause analysis:
In printOffsets, while the pointer `s` is advanced, the remaining
size `n` remains unchanged to be a constant 4096, and snprintf
falsely thinks the buffer has 4096 bytes left.
@jira-pull-request-webhook
Copy link

Hooray! The files in the branch are the same across the force-push. 😃

~ Your Friendly Jira-GitHub PR Checker Bot

@gvictor gvictor changed the title ICU-23155: Fix buffer overflow in SSearchTest::offsetTest() ICU-23155 Fix buffer overflow in SSearchTest::offsetTest() Jul 3, 2025
@gvictor gvictor requested a review from markusicu July 3, 2025 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@markusicu markusicu Awaiting requested review from markusicu

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@gvictor

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.