feat: add advanceTimers option #1402
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 9099fe3:
|
|
I don't believe the experimental react version test failures are due to these changes, as they also fail on main if I install experimental react & react-dom locally. But let me know if there's something I could do. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What: adding a new
advanceTimersconfiguration option to resolve #1197Possibly also #1393 and #1187, but maintainers are smarter than me about this, whether it also covers those.
Why: as this is currently not configurable, users have to use various workarounds to be able to use this library with vitest and fake timers, e.g.mock jest globals when they are not using jest
How:
advanceTimers, with the same name and signature thatuser-eventalready uses: https://github.com/testing-library/user-event/blob/main/src/options.ts#L127. Using the same name and signature should ensure best ecosystem compatibility.Checklist: