Fix audio response playback for non-GET requests by didzis · Pull Request #10228 · swagger-api/swagger-ui · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

Fix audio response playback for non-GET requests #10228

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

didzis
Copy link

@didzis didzis commented Nov 29, 2024

This PR is another attempt to fix #8378 when audio playback controller point to the URL of dynamically generated content and not the actual returned content (in browser memory).

Description

The difference of this PR from the previous attempt by the issue author is that this PR checks if the request method was other than GET (and thus is compatible with the default behavior) before trying to convert returned response content to a blob URL into browser cache memory.

Motivation and Context

The problem with the default approach before this PR is that it assumes the URL points to a static resource on the remote host, but in case of dynamically generated audio content (as it usually is the case with Text-to-Speech APIs), the REST API call requires extra parameters (without such the response is invalid) and is not reasonable to be run implicitly by browser.

Fixes #8378.

How Has This Been Tested?

Tested with POST request to a TTS (Text-to-Speech) API endpoint that generates audio response dynamically on-demand depending on extra parameters (query, body content etc.).

Screenshots (if appropriate):

Checklist

My PR contains...

  • No code changes (src/ is unmodified: changes to documentation, CI, metadata, etc.)
  • Dependency changes (any modification to dependencies in package.json)
  • Bug fixes (non-breaking change which fixes an issue)
  • Improvements (misc. changes to existing features)
  • Features (non-breaking change which adds functionality)

My changes...

  • are breaking changes to a public API (config options, System API, major UI change, etc).
  • are breaking changes to a private API (Redux, component props, utility functions, etc.).
  • are breaking changes to a developer API (npm script behavior changes, new dev system dependencies, etc).
  • are not breaking changes.

Documentation

  • My changes do not require a change to the project documentation.
  • My changes require a change to the project documentation.
  • If yes to above: I have updated the documentation accordingly.

Automated tests

  • My changes can not or do not need to be tested.
  • My changes can and should be tested by unit and/or integration tests.
  • If yes to above: I have added tests to cover my changes.
  • If yes to above: I have taken care to cover edge cases in my tests.
  • All new and existing tests passed.

tsukumijima added a commit to tsukumijima/swagger-ui that referenced this pull request Jun 3, 2025
Fix audio response playback for non-GET requests (Reproduction swagger-api#10228)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Audio returned by POST request is not playable.
1 participant

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.