chore: `reaction_sources` -> `source_ownership` by Rich-Harris · Pull Request #16287 · sveltejs/svelte · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

chore: reaction_sources -> source_ownership #16287

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2025
Merged

chore: reaction_sources -> source_ownership #16287

merged 2 commits into from
Jul 3, 2025
+20 −12

Conversation

Rich-Harris
Copy link
Member

Prompted by https://github.com/sveltejs/svelte/pull/15844/files#r2178611259 — the reaction_sources stuff is pretty inscrutable. Changing it to an object with named properties helps a bit, I think, (and I'd expect named properties to be microscopically faster to read than numbered ones) and doing the equality check before the .includes check is low-hanging fruit

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 2, 2025

⚠️ No Changeset found

Latest commit: e2ba9ef

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 2, 2025

Playground

pnpm add https://pkg.pr.new/svelte@16287

@Rich-Harris Rich-Harris mentioned this pull request Jul 2, 2025
Open
8 tasks
@Rich-Harris Rich-Harris merged commit 432763a into main Jul 3, 2025
14 checks passed
@Rich-Harris Rich-Harris deleted the source-ownership branch July 3, 2025 16:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dummdidumm dummdidumm dummdidumm approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Rich-Harris @dummdidumm

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.