fix: revert props legacy mode regression by dummdidumm · Pull Request #16279 · sveltejs/svelte · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

fix: revert props legacy mode regression #16279

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jul 1, 2025
Merged

fix: revert props legacy mode regression #16279

merged 1 commit into from
Jul 1, 2025
+6 −3

Conversation

dummdidumm
Copy link
Member

@dummdidumm dummdidumm commented Jul 1, 2025 •
edited
Loading

#16270 removed a condition which seemed to keep passing the corresponding test, but it actually introduced a regression since the PROPS_IS_UPDATED is always set when accessors should be created, which is the case by default in legacy mode tests. Setting accessors to false in the test reveals the regression, so this reverts that part of the refactoring.

No changeset since #16270 wasn't released yet

Before submitting the PR, please make sure you do the following

  • It's really useful if your PR references an issue where it is discussed ahead of time. In many cases, features are absent for a reason. For large changes, please create an RFC: https://github.com/sveltejs/rfcs
  • Prefix your PR title with feat:, fix:, chore:, or docs:.
  • This message body should clearly illustrate what problems it solves.
  • Ideally, include a test that fails without this PR but passes with it.
  • If this PR changes code within packages/svelte/src, add a changeset (npx changeset).

Tests and linting

  • Run the tests with pnpm test and lint the project with pnpm lint

@dummdidumm
fix: revert props legacy mode regression
fcdc698 
#16270 removed a condition which seemed to keep passing the corresponding test, but it actually introduced a regression since the PROPS_IS_UPDATED is always set when accessors should be created, which is the case by default in legacy mode tests. Setting accessors to false in the test reveals the regression, so this reverts that part of the refactoring
@svelte-docs-bot
Copy link

Preview: https://svelte-dev-git-preview-svelte-16279-svelte.vercel.app/

@dummdidumm dummdidumm mentioned this pull request Jul 1, 2025
Merged
6 tasks
@github-actions GitHub Actions
Copy link
Contributor

github-actions bot commented Jul 1, 2025

Playground

pnpm add https://pkg.pr.new/svelte@16279

@Rich-Harris
Copy link
Member

oops needs changeset, one sec

@changeset-bot changeset-bot
Copy link

changeset-bot bot commented Jul 1, 2025 •
edited
Loading

⚠️ No Changeset found

Latest commit: fcdc698

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@Rich-Harris
Copy link
Member

oh you already explained why no changeset. d'oh

@Rich-Harris Rich-Harris merged commit 2f68131 into main Jul 1, 2025
24 checks passed
@Rich-Harris Rich-Harris deleted the props-fix branch July 1, 2025 21:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Rich-Harris Rich-Harris Rich-Harris approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dummdidumm @Rich-Harris

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.