[SymmMem] Move code to where it is used #157611
Open
+68
−77
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157611
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 41ac62d with merge base a6fab82 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
pytorch-bot
bot
added
ciflow/h100-symm-mem
oncall: distributed
kwen2501
changed the title
Skylion007
approved these changes
Jul 4, 2025
Skylion007
reviewed
Jul 4, 2025
| // Print version | ||
| int major, minor; | ||
| ::nvshmem_info_get_version(&major, &minor); | ||
| LOG(INFO) << "NVSHMEM is available, version: " << major << "." << minor; |
There was a problem hiding this comment.
Suggested change
| LOG(INFO) << "NVSHMEM is available, version: " << major << "." << minor; | |
| LOG(INFO) << "NVSHMEM is available, version: " << major << '.' << minor; |
Skylion007
reviewed
Jul 4, 2025
| int result = (stmt); \ | ||
| TORCH_CHECK( \ | ||
| result == 0, \ | ||
| std::string(__FILE__) + ":" + std::to_string(__LINE__) + " " + msg + \ |
There was a problem hiding this comment.
Hmm, this string is always constructed whether the torch check fails or passes... Reformulate to c10::LazyStr or atleast fmtlib.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stack from ghstack (oldest at bottom):
maybe_initialize_env_varsandinitialize_nvshmem_with_storeare only used inNVSHMEMSymmetricMemory.cu. Moving them there.cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k