[aot] add format_consts_to_cpp function for further development. by xuhancn · Pull Request #157608 · pytorch/pytorch · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

[aot] add format_consts_to_cpp function for further development. #157608

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

xuhancn
Copy link
Collaborator

@xuhancn xuhancn commented Jul 4, 2025

Changes:

  1. split format_consts_to_asm function, which is current way to convert consts to object.
  2. add format_consts_to_cpp function, which would support for more compiler support, such as msvc and icx.

For format_consts_to_cpp, I have local tested it:
Case: https://docs.pytorch.org/docs/main/torch.compiler_aot_inductor.html
Run it and cat cpp code:
image

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @voznesenskym @penguinwu @EikanWang @Guobing-Chen @zhuhaozhe @blzheng @wenzhe-nrv @jiayisunx @ipiszy @chenyang78 @kadeng @muchulee8 @amjames @chauhang @aakhundov

Copy link

pytorch-bot bot commented Jul 4, 2025

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157608

Note: Links to docs will display an error until the docs builds have been completed.

⏳ No Failures, 5 Pending

As of commit eb40b92 with merge base 64f2ec7 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@xuhancn xuhancn added ciflow/trunk Trigger trunk jobs on your pull request topic: not user facing topic category and removed open source labels Jul 4, 2025
@xuhancn xuhancn added the intel This tag is for PR from Intel label Jul 4, 2025
@xuhancn xuhancn changed the title split format_consts_to_asm function. [aot] add format_consts_to_cpp function for further development. Jul 4, 2025
@xuhancn xuhancn marked this pull request as ready for review July 4, 2025 11:05
@xuhancn xuhancn requested a review from desertfire July 4, 2025 11:05
@xuhancn
Copy link
Collaborator Author

xuhancn commented Jul 4, 2025

@pytorchbot rebase

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased xu_consts_2_cpp onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout xu_consts_2_cpp && git pull --rebase)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/inductor ciflow/trunk Trigger trunk jobs on your pull request intel This tag is for PR from Intel module: inductor open source topic: not user facing topic category
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.