Fix doc issue 153531 by adding further explanation of STFT equation #157595
+22
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157595
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit 25ea584 with merge base 19ae5af ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
|
|
spzala
reviewed
Jul 3, 2025
There was a problem hiding this comment.
@michellemadubuike thanks! thanks! A quick feedback - please make sure build failures related to CLA check and label are taken care. Thanks!
|
@pytorchbot label "release notes: python_frontend" |
pytorch-bot
bot
added
the
release notes: python_frontend
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #153531
##Summary
This PR fixes doc issue #153531 by adding further explanation of STFT equation in torch/functional.py
##Details
I added further explanation of why the STFT equation exponent uses n_fft instead of win_length from lines 653 - 674. I did not think the issue required further explanation of the STFT equation as the explanation already present in the torch/functional.py seemed adequate