Fix einsum strategy shard dim > ndim by zpcore · Pull Request #157593 · pytorch/pytorch · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

Fix einsum strategy shard dim > ndim #157593

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

Fix einsum strategy shard dim > ndim #157593

wants to merge 1 commit into from
+20 −5

Conversation

zpcore
Copy link
Member

@zpcore zpcore commented Jul 3, 2025 •
edited by pytorch-bot bot
Loading

Previously we didn't constrain Shard dim to be <= the tensor's ndim. This cause an invalid strategy like (RR, RS(2)) -> RS(2), for einsum bmk,kn->bmn on the 2d mesh.

cc @H-Huang @awgu @wanchaol @fegin @fduwjj @wz337 @wconstab @d4l3k

@pytorch-bot PyTorch Bot
Copy link

pytorch-bot bot commented Jul 3, 2025 •
edited
Loading

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/157593

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit 4386086 with merge base 19ae5af (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@pytorch-bot pytorch-bot bot added ciflow/inductor oncall: distributed Add this issue/PR to distributed oncall triage queue labels Jul 3, 2025
@zpcore zpcore requested review from fmassa and wconstab July 3, 2025 22:29
@zpcore zpcore added the topic: not user facing topic category label Jul 3, 2025
@zpcore zpcore mentioned this pull request Jul 3, 2025
Open
5 tasks
@zpcore zpcore requested review from wanchaol and XilunWu July 3, 2025 22:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fmassa fmassa Awaiting requested review from fmassa

@wconstab wconstab Awaiting requested review from wconstab

@wanchaol wanchaol Awaiting requested review from wanchaol

@XilunWu XilunWu Awaiting requested review from XilunWu

Assignees
No one assigned
Labels
ciflow/inductor oncall: distributed Add this issue/PR to distributed oncall triage queue topic: not user facing topic category
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@zpcore

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.