Correct error display in _testcapi/vectorcall.c #136258
Open
+4
−4
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
Modules/_testcapi/vectorcall.c
Outdated
| @@ -179,13 +179,13 @@ _testcapi_VectorCallClass_set_vectorcall_impl(PyObject *self, | |||
| if (!PyObject_TypeCheck(self, type)) { | |||
| return PyErr_Format( | |||
| PyExc_TypeError, | |||
| "expected %s instance", | |||
| "expected %S instance", | |||
| PyType_GetName(type)); | |||
There was a problem hiding this comment.
This reference is leaked! This is an existing issue, but let's fix it in this PR.
Instead of using PyType_GetName and %S, let's just use %T.
ZeroIntensity
added
tests
Use %N instead of %S and PyType_GetName.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Correct incorrect conversion specifier in test from %s to %S for
PyObject *. I could have added a test, but that would be testing the test!