gh-135846: Add zstd dependency to Android build script by emmatyping · Pull Request #136253 · python/cpython · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

gh-135846: Add zstd dependency to Android build script #136253

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-135846: Add zstd dependency to Android build script #136253

wants to merge 1 commit into from
+1 −1

Conversation

emmatyping
Copy link
Member

@emmatyping emmatyping commented Jul 3, 2025 •
edited by bedevere-app bot
Loading

This PR adds libzstd to the Android platform build script. The source deps build script was added in beeware/cpython-android-source-deps#5.

The host configure found the libraries to enable _zstd:

checking for libzstd >= 1.4.5... yes
...
checking for stdlib extension module _zstd... yes

@bedevere-app bedevere-app bot mentioned this pull request Jul 3, 2025
Open
@emmatyping
Copy link
Member Author

!buildbot Android

@bedevere-bot
Copy link

🤖 New build scheduled with the buildbot fleet by @emmatyping for commit 8fe0fd9 🤖

Results will be shown at:

https://buildbot.python.org/all/#/grid?branch=refs%2Fpull%2F136253%2Fmerge

The command will test the builders whose names match following regular expression: Android

The builders matched are:

  • AMD64 Android PR
  • aarch64 Android PR

@emmatyping
Copy link
Member Author

Hmm, looks like libzstd.so.1 wasn't copied into the build package..

0:14:31 [491/491] test_zstd
test_zstd skipped -- dlopen failed: library "libzstd.so.1" not found: needed by /data/data/org.python.testbed/files/python/lib/python3.15/lib-dynload/_zstd.cpython-315-aarch64-linux-android.so in namespace clns-6
0:14:31 [491/491] test_zstd skipped

@emmatyping
Copy link
Member Author

Ah, I probably need to add libzstd here:

cpython/Android/android.py

Line 651 in da79ac9

("lib", ["engines-3", "libcrypto*.so", "libpython*", "libsqlite*",

@emmatyping
Copy link
Member Author

Hm, that isn't needed for bz2/lzma...

@mhsmith mhsmith added the needs backport to 3.14 bugs and security fixes label Jul 3, 2025
@mhsmith
Copy link
Member

mhsmith commented Jul 3, 2025 •
edited
Loading

Hm, that isn't needed for bz2/lzma...

That's because their cpython-android-source-deps releases only include static libraries. We should probably update the zstd build script to do the same. In that case, nothing would need to change in this PR except the zstd build number.

But FYI, if we did add any dynamic libraries, then we'd need to update not only the packaging script you linked above, but also the testbed here:

cpython/Android/testbed/app/build.gradle.kts

Lines 234 to 239 in b499105

generateTask(variant, variant.sources.jniLibs!!) {
for ((prefix, abi) in abis.entries) {
into(abi) {
from("$prefix/lib")
include("libpython*.*.so")
include("lib*_python.so")

@emmatyping
Copy link
Member Author

That's because their cpython-android-source-deps releases only include static libraries. We should probably update the zstd build script to do the same.

Oh! I didn't realize that, interesting. I'll make a PR now with that change.

@emmatyping
Copy link
Member Author

beeware/cpython-android-source-deps#6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhsmith mhsmith Awaiting requested review from mhsmith mhsmith is a code owner

@freakboy3742 freakboy3742 Awaiting requested review from freakboy3742 freakboy3742 is a code owner

Assignees
No one assigned
Labels
awaiting review needs backport to 3.14 bugs and security fixes skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emmatyping @bedevere-bot @mhsmith

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.