gh-136251: Improvements to WASM demo REPL #136252
Conversation
….worker.mjs can use it
adqm
requested review from
freakboy3742,
erlend-aasland and
corona10
as code owners
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
| updateHistory(){ | ||
| if (this.historyIndex !== -1){ | ||
| this.historyBuffer[this.historyIndex] = this.input; | ||
| }else{ |
There was a problem hiding this comment.
style nit:
| }else{ | |
| } else { |
| } | ||
|
|
||
| updateHistory(){ | ||
| if (this.historyIndex !== -1){ |
There was a problem hiding this comment.
style nit:
| if (this.historyIndex !== -1){ | |
| if (this.historyIndex !== -1) { |
| <div class="button-container"> | ||
| <button id="run" disabled>Run</button> | ||
| <button id="run" disabled>Run Code</button> |
There was a problem hiding this comment.
| <button id="run" disabled>Run Code</button> | |
| <button id="run" disabled>Run code</button> |
| } | ||
| }; | ||
|
|
||
| clearLine(){ | ||
| this.xterm.write('\x1b[K') |
There was a problem hiding this comment.
| this.xterm.write('\x1b[K') | |
| this.xterm.write('\x1b[K'); |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
thanks, @sobolevn! i just ran |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
I'm including a couple of fixes for the WASM demo, which for me made the demo "just work" out of the box for me with a build from following the instructions on this page:
HEAPU32at build time sincepython.worker.mjsexpects it to be there (for determining the version number)xterm.jsI also made a few changes to try to improve the usability of the web REPL, also included here:
textareawith Ace code editor.index.htmlinstead ofpython.htmlso that the URL shown in the terminal when runningserver.pytakes you to the demo (without needing to append/python.html)I also put up a demo here that shows the result of a fresh Emscripten build with these changes.
There's definitely still room for improvement here (for example, #124621 suggests updating the demo to use PyREPL), but I'm sharing these changes in case they're useful in the meantime.
Related Issue: #136251