gh-136193: Improve `TypeError` msg when comparing two `SimpleNamespace`s by sobolevn · Pull Request #136195 · python/cpython · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

gh-136193: Improve TypeError msg when comparing two SimpleNamespaces #136195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 2, 2025
Merged

gh-136193: Improve TypeError msg when comparing two SimpleNamespaces #136195

merged 2 commits into from
Jul 2, 2025
+27 −2

Conversation

sobolevn
Copy link
Member

@sobolevn sobolevn commented Jul 2, 2025 •
edited by bedevere-app bot
Loading

@sobolevn sobolevn requested review from ericvsmith and picnixz July 2, 2025 07:50
@bedevere-app bedevere-app bot mentioned this pull request Jul 2, 2025
Closed
efimov-mikhail
efimov-mikhail reviewed Jul 2, 2025
View reviewed changes
picnixz
picnixz reviewed Jul 2, 2025
View reviewed changes
efimov-mikhail
efimov-mikhail approved these changes Jul 2, 2025
View reviewed changes
Copy link
Contributor

@efimov-mikhail efimov-mikhail left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but I'm on renaming test to test_richcompare_unsupported.

@sobolevn @picnixz
Update Lib/test/test_types.py
e46cf19 
Co-authored-by: Bénédikt Tran <10796600+picnixz@users.noreply.github.com>
@sobolevn
Copy link
Member Author

sobolevn commented Jul 2, 2025

We usually don't backport error message changes, so I won't backport this as well.
In case anyone will need a backport - I am ok with creating one, when there's a clear use-case for it.

@sobolevn sobolevn merged commit ab7196a into python:main Jul 2, 2025
44 checks passed
@gold24kETH
Copy link

yes i waiting from this

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@efimov-mikhail efimov-mikhail efimov-mikhail approved these changes

@picnixz picnixz picnixz approved these changes

@ericvsmith ericvsmith Awaiting requested review from ericvsmith

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@sobolevn @gold24kETH @efimov-mikhail @picnixz

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.