gh-135075: Make PyObject_SetAttr() fail with NULL value and exception by vstinner · Pull Request #136180 · python/cpython · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

gh-135075: Make PyObject_SetAttr() fail with NULL value and exception #136180

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 12 commits into from
Jul 3, 2025
Merged

gh-135075: Make PyObject_SetAttr() fail with NULL value and exception #136180

merged 12 commits into from
Jul 3, 2025
+109 −9

Conversation

vstinner
Copy link
Member

@vstinner vstinner commented Jul 1, 2025 •
edited by github-actions bot
Loading

Make PyObject_SetAttr() and PyObject_SetAttrString() fail if called with NULL value and an exception set.

📚 Documentation preview 📚: https://cpython-previews--136180.org.readthedocs.build/

@vstinner
pythongh-135075: Make PyObject_SetAttr() fail with NULL value and exc…
145291d 
…eption

Make PyObject_SetAttr() and PyObject_SetAttrString() fail if called
with NULL value and an exception set.
@vstinner vstinner requested a review from ZeroIntensity as a code owner July 1, 2025 14:26
@bedevere-app bedevere-app bot mentioned this pull request Jul 1, 2025
Closed
@vstinner vstinner mentioned this pull request Jul 1, 2025
Closed
ZeroIntensity
ZeroIntensity reviewed Jul 1, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Generally looks good to me.

ZeroIntensity
ZeroIntensity reviewed Jul 1, 2025
View reviewed changes
ZeroIntensity
ZeroIntensity approved these changes Jul 1, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, LGTM.

serhiy-storchaka
serhiy-storchaka reviewed Jul 2, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that Modules/_testcapi/abstract.c is better place than Modules/_testcapi/object.c.

@vstinner
Copy link
Member Author

vstinner commented Jul 2, 2025

I think that Modules/_testcapi/abstract.c is better place than Modules/_testcapi/object.c.

I moved the C code.

serhiy-storchaka
serhiy-storchaka reviewed Jul 2, 2025
View reviewed changes
serhiy-storchaka
serhiy-storchaka reviewed Jul 3, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, although I think that the documentation could be improved.

@vstinner vstinner merged commit da79ac9 into python:main Jul 3, 2025
40 checks passed
@vstinner vstinner deleted the setattr_null_error branch July 3, 2025 12:51
@vstinner
Copy link
Member Author

vstinner commented Jul 3, 2025

Merged, thanks for reviews.

LGTM, although I think that the documentation could be improved.

I'm not good at writing documentation. Since the PR got multiple approvals, I merged my PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka left review comments

@encukou encukou encukou approved these changes

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@blockchainGuru1018 blockchainGuru1018 blockchainGuru1018 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@vstinner @encukou @serhiy-storchaka @ZeroIntensity @blockchainGuru1018

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.