gh-136097: Fix sysconfig._parse_makefile() by serhiy-storchaka · Pull Request #136166 · python/cpython · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

gh-136097: Fix sysconfig._parse_makefile() #136166

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

gh-136097: Fix sysconfig._parse_makefile() #136166

wants to merge 1 commit into from
+132 −87

Conversation

serhiy-storchaka
Copy link
Member

@serhiy-storchaka serhiy-storchaka commented Jul 1, 2025 •
edited
Loading

  • Fix potential infinite recursion.
  • Fix a bug when reference can cross boundaries of substitutions, e.g. a=$( b=$(a)a)
  • Fix potential quadratic complexity.
  • Fix KeyError for undefined CFLAGS, LDFLAGS, or CPPFLAGS.
  • Fix infinite recursion when keep_unresolved=False.
  • Unify behavior with keep_unresolved=False for bogus $ occurred before and after variable references.

@serhiy-storchaka serhiy-storchaka requested a review from FFY00 as a code owner July 1, 2025 11:45
@serhiy-storchaka serhiy-storchaka added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jul 1, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jul 1, 2025
Open
@serhiy-storchaka serhiy-storchaka removed needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jul 1, 2025
@serhiy-storchaka
pythongh-136097: Fix sysconfig._parse_makefile()
3888755 
* Fix potential infinite recursion.
* Fix a bug when reference can cross boundaries of substitutions, e.g.
  a=$(
  b=$(a)a)
* Fix potential quadratic complexity.
* Fix KeyError for undefined CFLAGS, LDFLAGS, or CPPFLAGS.
* Fix infinite recursion when keep_unresolved=False.
* Unify behavior with keep_unresolved=False for bogus $ occurred before
  and after variable references.
@serhiy-storchaka serhiy-storchaka force-pushed the sysconfig-parse_makefile branch from 967214c to 3888755 Compare July 1, 2025 12:31
vstinner
vstinner approved these changes Jul 2, 2025
View reviewed changes
Copy link
Member

@vstinner vstinner left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks for adding many tests.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vstinner vstinner vstinner approved these changes

@FFY00 FFY00 Awaiting requested review from FFY00 FFY00 is a code owner

Assignees
No one assigned
Labels
awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@serhiy-storchaka @vstinner

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.