gh-135836: Fix IndexError in asyncio.create_connection() #135875
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
serhiy-storchaka
requested review from
1st1,
asvetlov,
kumaraditya303 and
willingc
as code owners
serhiy-storchaka
added
needs backport to 3.13
It occurs when non-OSError exception is raised during connection and socket's close() raises OSError.
serhiy-storchaka
force-pushed
the
asyncio-create_connection-indexerror
branch
from
caa0472 to
2c7545f
Compare
kumaraditya303
approved these changes
Jul 3, 2025
|
Thanks @serhiy-storchaka for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 3, 2025
…ythonGH-135875) (cherry picked from commit 9084b151567d02936ea1374961809b69b4cd883d) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-136221 is a backport of this pull request to the 3.14 branch. |
miss-islington
pushed a commit
to miss-islington/cpython
that referenced
this pull request
Jul 3, 2025
…ythonGH-135875) (cherry picked from commit 9084b15) Co-authored-by: Serhiy Storchaka <storchaka@gmail.com>
|
GH-136222 is a backport of this pull request to the 3.13 branch. |
kumaraditya303
pushed a commit
that referenced
this pull request
Jul 3, 2025
kumaraditya303
pushed a commit
that referenced
this pull request
Jul 3, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It occurs when non-OSError exception is raised during connection and socket's close() raises OSError.