gh-135532: fortify DEBUG checks when fetching HACL*-based module state by picnixz · Pull Request #135844 · python/cpython · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

gh-135532: fortify DEBUG checks when fetching HACL*-based module state #135844

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

gh-135532: fortify DEBUG checks when fetching HACL*-based module state #135844

wants to merge 4 commits into from

Conversation

picnixz
Copy link
Member

@picnixz picnixz commented Jun 23, 2025 •
edited by bedevere-app bot
Loading

@picnixz picnixz requested review from gpshead and tiran as code owners June 23, 2025 10:48
@picnixz picnixz added the type-refactor Code refactoring (with no changes in behavior) label Jun 23, 2025
@bedevere-app bedevere-app bot mentioned this pull request Jun 23, 2025
Open
@picnixz

This comment was marked as resolved.

Sign in to view
@bedevere-bot

This comment was marked as resolved.

Sign in to view
@picnixz

This comment was marked as resolved.

Sign in to view
@bedevere-bot

This comment was marked as resolved.

Sign in to view
@picnixz
Copy link
Member Author

picnixz commented Jun 27, 2025

I'm tempted to merge this one, but at the same time, I'm tempted to have a more generic helper for such checks so that we can add it to every module that assumes _PyType_GetModuleState is safe.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gpshead gpshead Awaiting requested review from gpshead gpshead is a code owner

@tiran tiran Awaiting requested review from tiran tiran is a code owner

Assignees
No one assigned
Labels
awaiting core review skip news type-refactor Code refactoring (with no changes in behavior)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@picnixz @bedevere-bot

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.