Fix comments for heapq.siftup_max() by yoney · Pull Request #135359 · python/cpython · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

Fix comments for heapq.siftup_max() #135359

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jul 3, 2025
Merged

Fix comments for heapq.siftup_max() #135359

merged 2 commits into from
Jul 3, 2025

Conversation

yoney
Copy link
Contributor

@yoney yoney commented Jun 10, 2025

Fix the comments for the heapq module. The siftup() and siftup_max() functions are very similar, with only 1 line of difference. However, the siftup_max() still keeps the comments from the siftup().

Python version of siftup_max() has the correct comments

cpython/Lib/heapq.py

Line 308 in 0f866cb

def _siftup_max(heap, pos):

@yoney yoney marked this pull request as ready for review June 10, 2025 20:11
@yoney yoney requested a review from rhettinger as a code owner June 10, 2025 20:11
StanFromIreland
StanFromIreland approved these changes Jun 10, 2025
View reviewed changes
Copy link
Member

@StanFromIreland StanFromIreland left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

ZeroIntensity
ZeroIntensity approved these changes Jun 11, 2025
View reviewed changes
Copy link
Member

@ZeroIntensity ZeroIntensity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We generally don't accept changes to comments because they're considered cosmetic, but this one seems useful for maintenance purposes.

@kumaraditya303 kumaraditya303 merged commit 8f8bdf2 into python:main Jul 3, 2025
39 checks passed
@miss-islington-app
Copy link

Thanks @yoney for the PR, and @kumaraditya303 for merging it 🌮🎉.. I'm working now to backport this PR to: 3.13, 3.14.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 3, 2025
@yoney @mpage @miss-islington
Fix comments for heapq.siftup_max (pythonGH-135359)
3ac240a 
(cherry picked from commit 8f8bdf2)

Co-authored-by: Alper <alperyoney@fb.com>
Co-authored-by: mpage <mpage@meta.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 3, 2025

GH-136232 is a backport of this pull request to the 3.14 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jul 3, 2025
@yoney @mpage @miss-islington
Fix comments for heapq.siftup_max (pythonGH-135359)
40c3cad 
(cherry picked from commit 8f8bdf2)

Co-authored-by: Alper <alperyoney@fb.com>
Co-authored-by: mpage <mpage@meta.com>
@bedevere-app bedevere-app bot removed the needs backport to 3.14 bugs and security fixes label Jul 3, 2025
@bedevere-app
Copy link

bedevere-app bot commented Jul 3, 2025

GH-136233 is a backport of this pull request to the 3.13 branch.

@bedevere-app bedevere-app bot removed the needs backport to 3.13 bugs and security fixes label Jul 3, 2025
kumaraditya303 pushed a commit that referenced this pull request Jul 3, 2025
@miss-islington @yoney @mpage
[3.13] Fix comments for heapq.siftup_max (GH-135359) (#136233)
67c7439 
Fix comments for `heapq.siftup_max` (GH-135359)
(cherry picked from commit 8f8bdf2)

Co-authored-by: Alper <alperyoney@fb.com>
Co-authored-by: mpage <mpage@meta.com>
kumaraditya303 pushed a commit that referenced this pull request Jul 3, 2025
@miss-islington @yoney @mpage
[3.14] Fix comments for heapq.siftup_max (GH-135359) (#136232)
84cafc7 
Fix comments for `heapq.siftup_max` (GH-135359)
(cherry picked from commit 8f8bdf2)

Co-authored-by: Alper <alperyoney@fb.com>
Co-authored-by: mpage <mpage@meta.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mpage mpage mpage approved these changes

@ZeroIntensity ZeroIntensity ZeroIntensity approved these changes

@kumaraditya303 kumaraditya303 kumaraditya303 approved these changes

@StanFromIreland StanFromIreland StanFromIreland approved these changes

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees
No one assigned
Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@yoney @mpage @ZeroIntensity @kumaraditya303 @StanFromIreland

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.