gh-134567: Exposes log format to users in unittest.TestCase.assertLogs #134570
Conversation
|
All commit authors signed the Contributor License Agreement. |
|
Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool. If this change has little impact on Python users, wait for a maintainer to apply the |
|
@ezio-melotti @rbtcollins @gpshead @serhiy-storchaka Does anyone have any bandwidth to look a this one? I believe it will be a fairly quick either accept or reject type change. |
There was a problem hiding this comment.
"so your assertions can match a custom format" looks misleading. It can be misinterpreted as if assertLogs() itself checks that logging messages were formatted using the specified formatter. This is not true. assertLogs() does not check what formatter was used for the specified logger. It uses the specified formatter (or the default one) to format logging messages in output.
I suggest simply saying that a formatter is used to format the strings in output.
Can you clarify what's outstanding here? I thought I had addressed these with the previous commit. |
Ah got you, should be sorted now. Thanks for all your help and attention on this. |
|
LGTM. 👍 |
Allows users optionally to pass a custom log formatter to assertLogs such that assertions match expected custom formats where they are used. Existing behavior should be unaffected.