gh-115119: defer removal of bundled libmpdec to 3.16 by skirpichev · Pull Request #133997 · python/cpython · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

gh-115119: defer removal of bundled libmpdec to 3.16 #133997

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 2, 2025
Merged

gh-115119: defer removal of bundled libmpdec to 3.16 #133997

merged 7 commits into from
Jul 2, 2025

Conversation

skirpichev
Copy link
Contributor

@skirpichev skirpichev commented May 14, 2025 •
edited by github-actions bot
Loading

@skirpichev skirpichev requested a review from AA-Turner May 14, 2025 11:00
@skirpichev skirpichev added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels May 14, 2025
@bedevere-app bedevere-app bot added the docs Documentation in the Doc dir label May 14, 2025
@bedevere-app bedevere-app bot mentioned this pull request May 14, 2025
Open
15 tasks
@github-project-automation github-project-automation bot moved this to Todo in Docs PRs May 14, 2025
StanFromIreland
StanFromIreland reviewed May 14, 2025
View reviewed changes
@skirpichev skirpichev requested a review from hugovk May 15, 2025 06:47
@skirpichev
Copy link
Contributor Author

Oops, this seems to be not just a docs patch. I hope this still ok for backport.

@skirpichev skirpichev mentioned this pull request May 16, 2025
Merged
@skirpichev skirpichev requested review from vstinner and picnixz May 30, 2025 05:41
picnixz
picnixz reviewed Jun 2, 2025
View reviewed changes
Copy link
Member

@picnixz picnixz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't have much to say but I'm neutral on delaying the removal.

@hugovk hugovk removed their request for review June 2, 2025 11:06
@vstinner
Copy link
Member

vstinner commented Jun 2, 2025

defer removal of bundled libmpdec to 3.16

What is the rationale for defering the removal?

@skirpichev
Copy link
Contributor Author

What is the rationale for defering the removal?

You can see the issue thread.

For my humble opinion the only excuse is that we miss removal of the implicit fallback to bundled copy (now #134078) in 3.14. (Though, this wasn't announced somewhere else.) We also miss libmpdec in latest ubuntu images. (I think this will be solved before 3.14 release.)

@AA-Turner
Copy link
Member

For my humble opinion the only excuse is that we miss removal of the implicit fallback to bundled copy

I still think we can stick to the original plan (that is: remove the vendored copy in 3.15). The only issue to solve is installing development sources on Ubuntu for 24.04.

@skirpichev
Copy link
Contributor Author

FYI, I restored removal PR: #133964. I think libmpdec can be installed from PPA for PHP.

@skirpichev
Copy link
Contributor Author

This, probably, requires approval from the release manager. Though, @hugovk removed request for review.

@vstinner
Copy link
Member

This, probably, requires approval from the release manager. Though, @hugovk removed request for review.

Deferring a breaking change is always a good thing :-)

@hugovk
Copy link
Member

hugovk commented Jun 10, 2025

An RM decision isn't needed for normal feature changes in main aka 3.15. (And if it's deferred to 3.16, it's even less of this RM's decision :)

https://devguide.python.org/developer-workflow/development-cycle/#in-development-main-branch

@skirpichev
Copy link
Contributor Author

Deferring a breaking change is always a good thing :-)

Maybe.

An RM decision isn't needed for normal feature changes in main aka 3.15.

This affects 3.14 as well, as we change announced plans.

@vstinner
Copy link
Member

vstinner commented Jul 1, 2025

Since #134078 was just merged in Python 3.15, I think that it would be safe to postpone the removal to Python 3.16. Have one release with #134078 to see how it goes.

@skirpichev: There are now merge conflicts, can you try to address them?

@skirpichev skirpichev removed needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jul 1, 2025
@skirpichev
Copy link
Contributor Author

Oops, now it doesn't make less sense to backport this (configure.ac changes will be manual). It's expected to be merged first, not after #134078.

@skirpichev skirpichev added needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jul 1, 2025
@skirpichev skirpichev requested a review from vstinner July 1, 2025 16:42
@vstinner vstinner removed needs backport to 3.13 bugs and security fixes needs backport to 3.14 bugs and security fixes labels Jul 2, 2025
@vstinner vstinner merged commit b19c9da into python:main Jul 2, 2025
44 checks passed
@github-project-automation github-project-automation bot moved this from Todo to Done in Docs PRs Jul 2, 2025
@vstinner
Copy link
Member

vstinner commented Jul 2, 2025

Merged.

Oops, now it doesn't make less sense to backport this (configure.ac changes will be manual).

Do you mean that it doesn't make sense to backport this change, or that it should be backported manually?

@skirpichev skirpichev deleted the defer-libmpdec-removal/115119 branch July 2, 2025 09:32
@skirpichev
Copy link
Contributor Author

Do you mean that it doesn't make sense to backport this change

No, it does!

that it should be backported manually?

Yes. I'll do this.

skirpichev added a commit to skirpichev/cpython that referenced this pull request Jul 2, 2025
@skirpichev
[3.14] pythongh-115119: Defer removal of bundled libmpdec to 3.16 (py…
ac33099 
…thonGH-133997)

Rename libmpdecimal -> libmpdec

see https://www.bytereef.org/mpdecimal/doc/libmpdec/index.html
(cherry picked from commit b19c9da)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 2, 2025

GH-136199 is a backport of this pull request to the 3.14 branch.

skirpichev added a commit to skirpichev/cpython that referenced this pull request Jul 2, 2025
@skirpichev
[3.13] pythongh-115119: Defer removal of bundled libmpdec to 3.16 (py…
79caac3 
…thonGH-133997)

Rename libmpdecimal -> libmpdec

see https://www.bytereef.org/mpdecimal/doc/libmpdec/index.html
(cherry picked from commit b19c9da)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@bedevere-app
Copy link

bedevere-app bot commented Jul 2, 2025

GH-136201 is a backport of this pull request to the 3.13 branch.

vstinner pushed a commit that referenced this pull request Jul 2, 2025
@skirpichev
[3.14] gh-115119: Defer removal of bundled libmpdec to 3.16 (GH-133997)…
23a990d 
… (#136199)

Rename libmpdecimal -> libmpdec

see https://www.bytereef.org/mpdecimal/doc/libmpdec/index.html
(cherry picked from commit b19c9da)
vstinner pushed a commit that referenced this pull request Jul 2, 2025
@skirpichev
[3.13] gh-115119: Defer removal of bundled libmpdec to 3.16 (GH-133997)…
1e6db47 
… (#136201)

Rename libmpdecimal -> libmpdec

see https://www.bytereef.org/mpdecimal/doc/libmpdec/index.html
(cherry picked from commit b19c9da)

Co-authored-by: Sergey B Kirpichev <skirpichev@gmail.com>
@vstinner
Copy link
Member

vstinner commented Jul 2, 2025

I merged the 3.13 and 3.14 backports, thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StanFromIreland StanFromIreland StanFromIreland approved these changes

@AA-Turner AA-Turner Awaiting requested review from AA-Turner

@erlend-aasland erlend-aasland Awaiting requested review from erlend-aasland erlend-aasland is a code owner

@corona10 corona10 Awaiting requested review from corona10 corona10 is a code owner

@picnixz picnixz Awaiting requested review from picnixz

@vstinner vstinner Awaiting requested review from vstinner

Assignees
No one assigned
Labels
docs Documentation in the Doc dir skip news
Projects
Docs PRs
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@skirpichev @vstinner @AA-Turner @hugovk @picnixz @StanFromIreland

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.