gh-128213: fast path for bytes creation from list and tuple #132590
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sing PyNumber_AsSsize_t; fixed indentation
Misc/NEWS.d/next/Core_and_Builtins/2024-12-24-08-44-49.gh-issue-128213.Y71jDi.rst
Outdated
Show resolved
Hide resolved
Misc/NEWS.d/next/Core_and_Builtins/2024-12-24-08-44-49.gh-issue-128213.Y71jDi.rst
Outdated
Show resolved
Hide resolved
Objects/bytesobject.c
Outdated
Comment on lines
2871
to
2872
| /* Py_None as a fallback sentinel to the slow path */ | ||
| bytes = Py_None; |
There was a problem hiding this comment.
Suggested change
| /* Py_None as a fallback sentinel to the slow path */ | |
| bytes = Py_None; | |
| /* Py_None as a fallback sentinel to the slow path */ | |
| Py_INCREF(Py_None); | |
| bytes = Py_None; |
Is needed, no?
There was a problem hiding this comment.
Py_None is immortal, so not needed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Continuation of #128214. This PR