gh-87790: support thousands separators for formatting fractional part of Fraction's by skirpichev · Pull Request #132204 · python/cpython · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

gh-87790: support thousands separators for formatting fractional part of Fraction's #132204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

gh-87790: support thousands separators for formatting fractional part of Fraction's #132204

wants to merge 2 commits into from
+24 −1

Conversation

skirpichev
Copy link
Contributor

@skirpichev skirpichev commented Apr 7, 2025 •
edited by bedevere-app bot
Loading

@bedevere-app bedevere-app bot mentioned this pull request Apr 7, 2025
Open
serhiy-storchaka
serhiy-storchaka reviewed Jul 3, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Test also errors for '.f' and '.6_f'.

@skirpichev
Copy link
Contributor Author

Test also errors for '.f' and '.6_f'.

I suspect you are about ._6f. This test was added in test_invalid_formats(). Missing precision already was tested.

@serhiy-storchaka serhiy-storchaka requested a review from hugovk July 3, 2025 13:02
@serhiy-storchaka serhiy-storchaka added the needs backport to 3.14 bugs and security fixes label Jul 3, 2025
serhiy-storchaka
serhiy-storchaka approved these changes Jul 3, 2025
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

@picnixz picnixz Awaiting requested review from picnixz

@hugovk hugovk Awaiting requested review from hugovk

Assignees
No one assigned
Labels
awaiting merge needs backport to 3.14 bugs and security fixes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@skirpichev @serhiy-storchaka

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.