-
Notifications
You must be signed in to change notification settings - Fork 563
Add PHP History Timeline #1284
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Add PHP History Timeline #1284
Conversation
🚀 Regression report for commit 187070c is at https://web-php-regression-report-pr-1284.preview.thephp.foundation |
🚀 Preview for commit 187070c can be found at https://web-php-pr-1284.preview.thephp.foundation |
Add PHP History page, updated tests
Looks great, thanks! Please note Sara's comment (I suppose we can wait for others to weigh in as well). IMO: I don't see a problem with web-php review for changes like this, as it's no more work than user conference review, but I'd be happy to hear from others. |
Thanks, I get the point with the wiki idea, I just struggle a bit with some flows around it. Will summarize everything and reply to the comment directly. Something strange happened with the visual regression test. Screen was updated, yet if failed again. I will check this again. |
Update tests-screenshots-index-php-chromium.png
@saundefined we are now working on running the visual tests locally, so we can check why it fails. |
@mkurzeja the last visual test looks awesome! 🎉 |
Initial implementation of #1265
This adds two main changes:
https://drop.accesto.com/v/f0cATp
Events from years 2020-2025 are not included in this PR, I will create a separate one.