Make parameter $column_key optional in array_column() #18994
+27
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Looking at the documentation (https://www.php.net/manual/en/function.array-column.php), I'm seeing there is not currently an example for this use case. Would you be interested in sending a PR? That would probably be a good first step to “advertise” this feature a little more. Personally I wasn't aware that this was possible yet. As for the change itself: I'm not sure if “reindexing” an array should be the default use case for this function. I'd rather say that the user should be forced to make an explicit choice to make accidental misuse / typos less likely. So a discussion on Internals should happen at least. The patch itself LGTM, though. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Quite often in my code I reindex object collections via
array_column. However, I have to explicitly passnullto$column_keyinstead of skipping it. Here's a change that makes possible this:Does it require a discussion in internals or an RFC?