Use generated parameter parsing for KDFs #27923
Open
+1,211
−1,045
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
paulidale
added
branch: master
github-actions
bot
added
the
severity: fips change
paulidale
added
approval: review pending
paulidale
force-pushed
the
param-kdf
branch
5 times, most recently
from
f51e837 to
1a22f71
Compare
|
Should be ready for reviewing. |
|
Rebased to resolve trivial conflict. Reviews @openssl/committers ? |
The generated parameter parsers don't accept duplication of parameters so this causes an error at runtime if not seperated.
The code already skips "properties" and "engines" behaves the same.
These are in the name decoder and structure but do not appear in the parameter listing.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
KDFs are OSSL_PARAM heavy and widely used. Switching to a generated name parser should improve performance a bit. We'll also gain forced consistency between advertised parameter lists and what is actually accepted.
This requires some changes to the parser generator to support duplicated parameters.
It also requires changes to the KDF code to use the parser.
If additionally requires changes to some of the helper functions so they don't attempt to locate parameters.