Add lock contention log analyzer #27912
Closed
+114
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nhorman
requested review from
Sashan,
levitte,
t8m,
mattcaswell,
jogme and
andrewkdinh
andrewkdinh
suggested changes
Jun 27, 2025
t8m
added
branch: master
t8m
previously approved these changes
Jun 27, 2025
nhorman
force-pushed
the
add-contention-analysis
branch
from
1994f50 to
f6218ed
Compare
t8m
previously approved these changes
Jun 27, 2025
andrewkdinh
approved these changes
Jun 30, 2025
mattcaswell
requested changes
Jul 1, 2025
mattcaswell
requested changes
Jul 1, 2025
With the introduction of REPORT_RWLOCK_CONTENTION, it would be nice if we could do some quick analysis on it. This script parses the log, and generates a histogram of lock contention events, uniquely identified by the stack trace that caused it, and prints out all unique latency event, sorted from largest (as measured by cumulative latency in that path).
nhorman
force-pushed
the
add-contention-analysis
branch
from
f6218ed to
6b52a00
Compare
mattcaswell
previously approved these changes
Jul 2, 2025
Co-authored-by: Matt Caswell <matt@openssl.org>
t8m
approved these changes
Jul 2, 2025
mattcaswell
approved these changes
Jul 3, 2025
mattcaswell
added
approval: done
openssl-machine
added
approval: ready to merge
|
This pull request is ready to merge |
|
merged to master, thank you! |
github-project-automation
bot
moved this from Waiting Merge
to Done
in Development Board
openssl-machine
pushed a commit
that referenced
this pull request
Jul 4, 2025
With the introduction of REPORT_RWLOCK_CONTENTION, it would be nice if we could do some quick analysis on it. This script parses the log, and generates a histogram of lock contention events, uniquely identified by the stack trace that caused it, and prints out all unique latency event, sorted from largest (as measured by cumulative latency in that path). Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #27912)
openssl-machine
pushed a commit
that referenced
this pull request
Jul 4, 2025
Co-authored-by: Matt Caswell <matt@openssl.org> Reviewed-by: Tomas Mraz <tomas@openssl.org> Reviewed-by: Matt Caswell <matt@openssl.org> (Merged from #27912)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
With the introduction of REPORT_RWLOCK_CONTENTION, it would be nice if we could do some quick analysis on it.
This script parses the log, and generates a histogram of lock contention events, uniquely identified by the stack trace that caused it, and prints out the top 10 most egregious contention offenders, along with the total amount of usecs spent waiting on that contention point.