ktls: move ktls_enable() within ktls_start() #27908
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
openssl-machine
added
the
hold: cla required
|
This might be acceptable with CLA: trivial as it is mostly removals and one function call moved to a different place. Could you please amend the commit message to contain CLA: trivial on a separate line or submit a regular CLA? |
t8m
added
branch: master
On linux ktls can only be enabled on established TCP sockets. When SSL_set_fd() is called before the connection is established ktls_enable() fails and ktls is not setup. This moves ktls_enable() call within then ktls_start() function. Multiple calls to ktls_start() will trigger additional ktls_enable() calls which fail with EEXIST, but do not affect the ktls socket. CLA: trivial Signed-off-by: Ulrich Weber <ulrich.weber@gmail.com>
openssl-machine
removed
the
hold: cla required
done |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On linux ktls can only be enabled on established TCP sockets. When SSL_set_fd() is called before the connection is established ktls_enable() fails and ktls is not setup.
This moves ktls_enable() call within then ktls_start() function. Multiple calls to ktls_start() will trigger additional ktls_enable() calls which fail with EEXIST, but do not affect the ktls socket.
Fixes #19676