crypto/slh_dsa/slh_hash.c: Add check for EVP_MD_get_size() #27900
+3
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add the check for the return value of EVP_MD_get_size() to avoid invalid size. Fixes: 2f9e152 ("Add SLH_DSA signature verification.") Signed-off-by: Jiasheng Jiang <jiashengjiangcool@gmail.com>
github-actions
bot
added
the
severity: fips change
paulidale
approved these changes
Jun 26, 2025
paulidale
added
branch: master
slontis
reviewed
Jun 26, 2025
| @@ -158,6 +158,9 @@ slh_hmsg_sha2(SLH_DSA_HASH_CTX *hctx, const uint8_t *r, const uint8_t *pk_seed, | |||
| int sz = EVP_MD_get_size(hctx->key->md_big); | |||
| size_t seed_len = (size_t)sz + 2 * n; | |||
|
|
|||
| if (sz <= 0) | |||
There was a problem hiding this comment.
The only possible values for the digest here are "SHA2-256" or "SHA2-512".. i.e. the NULL case would error.. So this seems unlikely.
There was a problem hiding this comment.
True, the current logic only allows "SHA2-256" and "SHA2-512", so a NULL shouldn't occur. But the check is mostly for robustness — just in case future changes introduce new callers that might pass an unexpected digest. It’s a small safeguard to make the function more resilient.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add the check for the return value of EVP_MD_get_size() to avoid invalid size.
Fixes: 2f9e152 ("Add SLH_DSA signature verification.")
Checklist