Add threading support to the FIPS provider. by slontis · Pull Request #25537 · openssl/openssl · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

Add threading support to the FIPS provider. #25537

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

slontis
Copy link
Member

@slontis slontis commented Sep 25, 2024

The FIPS provider does not include threading code directly. The core passes thread related methods to the providers so that the FIPS provider has access to threading.
This allows complex algorithms such as ARGON or HSS to use threads once they are implemented in the FIPS provider.

An existing PR for HSS will use and test this code.

Checklist
  • documentation is added or updated
  • tests are added or updated

The FIPS provider does not include threading code directly.
The core passes thread related methods to the providers so that
the FIPS provider has access to threading.
This allows complex algorithms such as ARGON or HSS to use threads
once they are implemented in the FIPS provider.

An existing PR for HSS will use and test this code.
@slontis slontis added branch: master Merge to master branch approval: review pending This pull request needs review by a committer triaged: feature The issue/pr requests/adds a feature tests: deferred Tests will be added in a subsequent PR (label should be removed when the PR with tests is merged) labels Sep 25, 2024
@github-actions github-actions bot added the severity: fips change The pull request changes FIPS provider sources label Sep 25, 2024
@slontis slontis added the style: waived exempted from style checks label Sep 25, 2024
@@ -15,6 +15,9 @@
# include <openssl/core.h>
# include <openssl/indicator.h>

/* Note that this matches CRYPTO_THREAD_ROUTINE */
typedef uint32_t (*OSSL_thread_start_handler_fn)(void *);
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Note that the thread code is internal which is why this is defined here

@paulidale
Copy link
Contributor

Argon isn't available in FIPS yet.
HSS will be in due course.

@slontis
Copy link
Member Author

slontis commented Sep 25, 2024

Rather than have people review roughly 70 files for the HSS work, I think it makes sense to break up the work into digestable sized PR's that have a chance of being more thoroughly reviewed. This is one such PR.

@slontis
Copy link
Member Author

slontis commented Sep 25, 2024

@t8m
Copy link
Member

t8m commented Sep 25, 2024

Should the HSS have a feature branch then?

@slontis
Copy link
Member Author

slontis commented Sep 25, 2024

Dont really see why it needs a feature branch. The work is mainly done.

@t-j-h
Copy link
Member

t-j-h commented Sep 25, 2024

I think a feature branch makes sense - the review process is going to be "fun" and then we can keep it ready to hit the tree in a single chunk once all the various PRs get reviewed.

@slontis
Copy link
Member Author

slontis commented Sep 25, 2024

Is the 'feature' branch process documented somewhere? Am I supposed to create it?

@slontis
Copy link
Member Author

slontis commented Sep 25, 2024

For things such as #25499 I dont think they need to be on a feature branch.. (i.e.- a general fix).

@nhorman
Copy link
Contributor

nhorman commented Sep 25, 2024

concur with feature branch suggestion. I think we need to start moving more work to feature branches to make inclusion decisions later in the development cycle more manageable

@openssl-machine
Copy link
Collaborator

This PR is in a state where it requires action by @openssl/committers but the last update was 30 days ago

@openssl-machine
Copy link
Collaborator

This PR is in a state where it requires action by @openssl/committers but the last update was 61 days ago

@openssl-machine
Copy link
Collaborator

This PR is in a state where it requires action by @openssl/committers but the last update was 92 days ago

@openssl-machine
Copy link
Collaborator

This PR is in a state where it requires action by @openssl/committers but the last update was 123 days ago

@openssl-machine
Copy link
Collaborator

This PR is in a state where it requires action by @openssl/committers but the last update was 154 days ago

@openssl-machine
Copy link
Collaborator

This PR is in a state where it requires action by @openssl/committers but the last update was 185 days ago

@openssl-machine
Copy link
Collaborator

This PR is in a state where it requires action by @openssl/committers but the last update was 216 days ago

@openssl-machine
Copy link
Collaborator

This PR is in a state where it requires action by @openssl/committers but the last update was 247 days ago

@openssl-machine
Copy link
Collaborator

This PR is in a state where it requires action by @openssl/committers but the last update was 278 days ago

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approval: review pending This pull request needs review by a committer branch: master Merge to master branch severity: fips change The pull request changes FIPS provider sources style: waived exempted from style checks tests: deferred Tests will be added in a subsequent PR (label should be removed when the PR with tests is merged) triaged: feature The issue/pr requests/adds a feature
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.