Nodes: Inject shader name into shader #31363
Draft
+16
−5
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
📦 Bundle sizeFull ESM build, minified and gzipped.
🌳 Bundle size after tree-shakingMinimal build including a renderer, camera, empty scene, and dependencies.
|
Mugen87
reviewed
Jul 4, 2025
| this.vertexShader = this._getGLSLVertexCode( shadersData.vertex ); | ||
| this.fragmentShader = this._getGLSLFragmentCode( shadersData.fragment ); | ||
| const name = this.material.name; | ||
| const shaderName = ( name !== '' ) ? name : this.material.constructor.name; |
There was a problem hiding this comment.
How about adding name to the shadersData object (with '' as the default)?
const shadersData = this.material !== null ? { name: '', fragment: {}, vertex: {} } : { name: '', compute: {} };In this way, there is no need to change the signature of _getGLSLVertexCode() and _getGLSLFragmentCode().
There was a problem hiding this comment.
WGSLNodeBuilder should also be updated.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a shader name to the Node-based shaders has been very helpful to me.
Perhaps the implementation in this PR can be improved, but I like the concept.