Shorten Agg template usage with class template argument deduction. by anntzer · Pull Request #29763 · matplotlib/matplotlib · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

Shorten Agg template usage with class template argument deduction. #29763

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

anntzer
Copy link
Contributor

@anntzer anntzer commented Mar 17, 2025

Many parts of the Agg & path processing pipeline work by constructing nested templated objects that represent steps of the processing pipeline, e.g. (simplified example)

agg::conv_transform<mpl::PathIterator>  // The processing step.
    tpath  // The name of the result.
        (path, trans);  // The arguments passed to the processing step.
PathNanRemover<agg::conv_transform<mpl::PathIterator>>
    nan_removed
        (tpath, true, path.has_codes());

The current implementation makes the code shorter by introducing alias typenames for the types at each intermediate step.

As of C++17, this can be made simpler and shorter because class template argument deduction ("CTAD") allows not specifying the template arguments (in angle brackets) anymore, i.e. one can write

agg::conv_transform tpath(path, trans);
PathNanRemover nan_removed(tpath, true, path.has_codes());

and the compiler will auto-fill in the required types.

Furthermore, because these steps can be seen as a pipeline (even though they are implemented as the construction of nested objects), it may feel more natural to write them as repeated "function" (constructor) application, i.e.

auto tpath = agg::conv_transform{path, trans};
auto nan_removed = PathNanRemover{tpath, true, path.has_codes()};

Perform this transformation whereever applicable.

(Noted while looking at the implementation for #29711 (comment)...)

PR summary

PR checklist

Many parts of the Agg & path processing pipeline work by constructing
nested templated objects that represent steps of the processing
pipeline, e.g. (simplified example)
```
agg::conv_transform<mpl::PathIterator>  // The processing step.
    tpath  // The name of the result.
        (path, trans);  // The arguments passed to the processing step.
PathNanRemover<agg::conv_transform<mpl::PathIterator>>
    nan_removed
        (tpath, true, path.has_codes());
```
The current implementation makes the code shorter by introducing alias
typenames for the types at each intermediate step.

As of C++17, this can be made simpler and shorter because class template
argument deduction ("CTAD") allows not specifying the template arguments
(in angle brackets) anymore, i.e. one can write
```
agg::conv_transform tpath(path, trans);
PathNanRemover nan_removed(tpath, true, path.has_codes());
```
and the compiler will auto-fill in the required types.

Furthermore, because these steps can be seen as a pipeline (even though
they are implemented as the construction of nested objects), it may feel
more natural to write them as repeated "function" (constructor)
application, i.e.
```
auto tpath = agg::conv_transform{path, trans};
auto nan_removed = PathNanRemover{tpath, true, path.has_codes()};
```

Perform this transformation whereever applicable.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.