WOP: APIGW add ipAddressType field in endpointConfiguration by ArthurAkh · Pull Request #12826 · localstack/localstack · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

WOP: APIGW add ipAddressType field in endpointConfiguration #12826

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Draft
wants to merge 5 commits into
base: master
Choose a base branch
from
Draft

WOP: APIGW add ipAddressType field in endpointConfiguration #12826

wants to merge 5 commits into from

Conversation

ArthurAkh
Copy link
Contributor

@ArthurAkh ArthurAkh commented Jul 2, 2025 •
edited
Loading

Motivation

AWS recently introduced the ipAddressType field for API Gateway Rest APIs, defaulting to "ipv4".
LocalStack needs to mimic this behavior to maintain parity.

Related docs:

Changes

  • Added support for returning endpointConfiguration.ipAddressType in CreateRestApi.
  • Updated relevant snapshot tests in TestApiGatewayApiRestApi.

@ArthurAkh
add ipAddressType field in endpointConfiguration, add validation logi…
e865870 
…c, add additional tests, update snapshots in test_apigateway_api.py
@ArthurAkh ArthurAkh self-assigned this Jul 2, 2025
@ArthurAkh ArthurAkh added the semver: patch Non-breaking changes which can be included in patch releases label Jul 2, 2025
@ArthurAkh ArthurAkh added this to the 4.7 milestone Jul 2, 2025
@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2025 •
edited
Loading

Test Results - Preflight, Unit

21 795 tests  ±0   20 138 ✅ ±0   6m 17s ⏱️ -6s
     1 suites ±0    1 657 💤 ±0 
     1 files   ±0        0 ❌ ±0 

Results for commit 2718f16. ± Comparison against base commit 583b620.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 2, 2025 •
edited
Loading

LocalStack Community integration with Pro

    2 files  ±    0      2 suites  ±0   19m 3s ⏱️ - 1h 25m 10s
1 153 tests  - 3 760  1 087 ✅  - 3 050  66 💤  - 710  0 ❌ ±0 
1 155 runs   - 3 760  1 087 ✅  - 3 050  68 💤  - 710  0 ❌ ±0 

Results for commit 2718f16. ± Comparison against base commit 583b620.

This pull request removes 3763 and adds 3 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.apigateway.test_apigateway_api.TestApiGatewayApiRestApi ‑ test_create_rest_api_private_type
tests.aws.services.apigateway.test_apigateway_api.TestApiGatewayApiRestApi ‑ test_create_rest_api_verify_defaults
tests.aws.services.apigateway.test_apigateway_api.TestApiGatewayApiRestApi ‑ test_create_rest_api_with_endpoint_configuration

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2025 •
edited
Loading

Test Results (amd64) - Acceptance

7 tests  ±0   5 ✅ ±0   3m 8s ⏱️ -6s
1 suites ±0   2 💤 ±0 
1 files   ±0   0 ❌ ±0 

Results for commit 2718f16. ± Comparison against base commit 583b620.

♻️ This comment has been updated with latest results.

@github-actions GitHub Actions
Copy link

github-actions bot commented Jul 3, 2025 •
edited
Loading

Test Results (amd64) - Integration, Bootstrap

    5 files  ±    0      5 suites  ±0   36m 10s ⏱️ - 1h 45m 46s
1 177 tests  - 4 093  1 111 ✅  - 3 231  66 💤  - 862  0 ❌ ±0 
1 183 runs   - 4 093  1 111 ✅  - 3 231  72 💤  - 862  0 ❌ ±0 

Results for commit 2718f16. ± Comparison against base commit 583b620.

This pull request removes 4096 and adds 3 tests. Note that renamed tests count towards both. 
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_lambda_dynamodb
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_opensearch_crud
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_search_books
tests.aws.scenario.bookstore.test_bookstore.TestBookstoreApplication ‑ test_setup
tests.aws.scenario.kinesis_firehose.test_kinesis_firehose.TestKinesisFirehoseScenario ‑ test_kinesis_firehose_s3
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_destination_sns
tests.aws.scenario.lambda_destination.test_lambda_destination_scenario.TestLambdaDestinationScenario ‑ test_infra
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_prefill_dynamodb_table
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input0-SUCCEEDED]
tests.aws.scenario.loan_broker.test_loan_broker.TestLoanBrokerScenario ‑ test_stepfunctions_input_recipient_list[step_function_input1-SUCCEEDED]
…

tests.aws.services.apigateway.test_apigateway_api.TestApiGatewayApiRestApi ‑ test_create_rest_api_private_type
tests.aws.services.apigateway.test_apigateway_api.TestApiGatewayApiRestApi ‑ test_create_rest_api_verify_defaults
tests.aws.services.apigateway.test_apigateway_api.TestApiGatewayApiRestApi ‑ test_create_rest_api_with_endpoint_configuration

♻️ This comment has been updated with latest results.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bentsku bentsku Awaiting requested review from bentsku bentsku will be requested when the pull request is marked ready for review bentsku is a code owner

@cloutierMat cloutierMat Awaiting requested review from cloutierMat cloutierMat will be requested when the pull request is marked ready for review cloutierMat is a code owner

At least 1 approving review is required to merge this pull request.

Assignees

@ArthurAkh ArthurAkh

Labels
semver: patch Non-breaking changes which can be included in patch releases
Projects
None yet
Milestone
4.7
Development

Successfully merging this pull request may close these issues.
1 participant
@ArthurAkh

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.