-
-
Notifications
You must be signed in to change notification settings - Fork 4.2k
LDM as provisioner of debug-enabled containers #12824
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Test Results (amd64) - Integration, Bootstrap 5 files 5 suites 2h 24m 13s ⏱️ Results for commit 3feac01. ♻️ This comment has been updated with latest results. |
32e729d
to
fec91f6
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Did you run an LDM flow manually to verify all works fine? Also, I did a rebase since I wanted to do a full run against pro and some changes were not present in your branch.
Happy to merge once we have:
- A green pro CI run.
- Manual verification of LDM.
|
||
if not lambda_arn: | ||
return lambda_arn | ||
lambda_arn_parts = lambda_arn.split(":") |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit: Should we not specifically be checking if the service is lambda
? Perhaps we should use api_utils.function_locators_from_arn
or localstack.utils.aws.arns.parse_arn
.
…calstack into MEP-LDM-LDM_as_provisioner
Motivation
The current LDM implementation depends heavily on the Lambda service’s container provisioning logic, injecting LDM-specific parameter overrides throughout various parts of the service to support debug-enabled containers. This fragmented integration makes LDM difficult to maintain and limits control over the lifecycle of debug-enabled containers. This refactor centralizes LDM responsibilities by transforming it into a dedicated provisioner for debug-enabled containers. As a result, the Lambda service is relieved of most LDM-related logic. Additionally, these changes ensure that debug-enabled containers persist across multiple invocations, allowing the debug client to remain connected or reconnect after disconnections.
Changes