[12.x] Return early on belongs-to-many relationship `syncWithoutDetaching` method when empty values are given by stevebauman · Pull Request #56157 · laravel/framework · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

[12.x] Return early on belongs-to-many relationship syncWithoutDetaching method when empty values are given #56157

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jun 28, 2025

Conversation

stevebauman
Copy link
Contributor

@stevebauman stevebauman commented Jun 27, 2025

This is a small change to prevent an unnecessary query from being executed when calling syncWithoutDetaching with an empty value or collection (collect(), [], or null).

Without this, we have to check every time to ensure the values are present instead of the framework automatically handling this. Over time, this can reduce a lot of conditions from being created unnecessarily, as well as SQL queries.

Before:

if ($tags->isNotEmpty()) {
    $post->tags()->syncWithoutDetaching($tags);
}

After:

$post->tags()->syncWithoutDetaching($tags);

@taylorotwell taylorotwell merged commit 4065ab7 into laravel:12.x Jun 28, 2025
60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.