[12.x] Allow globally disabling Factory parent relationships #56154
+24
−3
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Would a descriptive method be more Laravel-y? UserPermissionFactory::disableExpandedRelationships() |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A continuation of #53450. This feature was added by @browner12 and it's been incredibly helpful for our team in speeding up tests.
That said, it requires us to write
->withoutParents()on each factory make, which has led to bugs. Namely, we don't add the trait to refresh the database and then data gets left over between tests, which breaks expectations in other tests... but we don't discover it for a month 😆 😭 and then it's debug city.It would be great if in the test's setup, we can just indicate no factory should create a parent relationship.
public function test_has_one_editor_permission_returns_true(): void { + UserPermissionFactory::$defaultExpandRelationships = false; + $collection = new UserPermissionCollection([ UserPermission::factory() - ->withoutParents() ->make([ 'type' => 'viewer', 'company_id' => 2, 'product_id' => 789, ]), UserPermission::factory() - ->withoutParents() ->make([ 'type' => 'editor', 'company_id' => 2, 'product_id' => 432, ]), ]); $result = $collection->hasEditorForCompany(2); $this->assertTrue($result); }Even better, I would just add this to the class's
setUp()method.