DRA kubelet: add v1 gRPC by pohly · Pull Request #132700 · kubernetes/kubernetes · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

DRA kubelet: add v1 gRPC #132700

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

DRA kubelet: add v1 gRPC #132700

wants to merge 1 commit into from
+3,276 −63

Conversation

pohly
Copy link
Contributor

@pohly pohly commented Jul 3, 2025

What type of PR is this?

/kind feature
/kind deprecation

What this PR does / why we need it:

The API is a direct copy of v1beta1, with v1beta1 replaced by v1. The interoperability support is the same that was used for v1alpha4. Adding it "reverts" the removal of the v1alpha4 support in a57f15e, except that now v1beta1 is the legacy API which needs conversion. If kubelet and the plugin both support v1, no conversion is needed.

Which issue(s) this PR is related to:

#131903
KEP: kubernetes/enhancements#4381

Special notes for your reviewer:

Does this PR introduce a user-facing change?

I think we want to start moving DRA drivers off v1beta1, therefore I am explicitly calling out the deprecation.

DRA kubelet: gRPC API graduated to v1, v1beta1 is deprecated starting in 1.34. Updating DRA drivers to the k8s.io/dynamic-resource-allocation/kubeletplugin helper from 1.34 adds support for both API versions.

@k8s-ci-robot k8s-ci-robot added release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/feature Categorizes issue or PR as related to a new feature. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 3, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/kubelet area/test sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. labels Jul 3, 2025
@k8s-ci-robot k8s-ci-robot added wg/device-management Categorizes an issue or PR as relevant to WG Device Management. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 3, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: pohly
Once this PR has been reviewed and has the lgtm label, please assign klueska for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

pohly added a commit to pohly/kubernetes that referenced this pull request Jul 3, 2025
@pohly
merge kubernetes#132700 dra-kubelet-grpc-v1
0167330
@pohly
Copy link
Contributor Author

pohly commented Jul 3, 2025

n-2 and n-1 fail because the v1beta2 gRPC API is off by default in the tests. It should be on, to mirror the default behavior, and then the "only v1" E2E tests must be limited to kubelet >= 1.34.

@pohly pohly mentioned this pull request Jul 3, 2025
Open
31 tasks
@pohly pohly force-pushed the dra-kubelet-grpc-v1 branch 2 times, most recently from 6497b51 to 6a78211 Compare July 3, 2025 17:48
@kannon92 kannon92 moved this from Triage to Archive-it in SIG Node CI/Test Board Jul 3, 2025
@pohly pohly force-pushed the dra-kubelet-grpc-v1 branch from 6a78211 to 14bb107 Compare July 3, 2025 19:48
@pohly
Copy link
Contributor Author

pohly commented Jul 4, 2025

/hold

We need to merge this when we are ready to go GA.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 4, 2025
@pohly pohly force-pushed the dra-kubelet-grpc-v1 branch from 14bb107 to 4241e4c Compare July 4, 2025 05:37
@pohly
DRA kubelet: add v1 gRPC
29828c1 
The API is a direct copy of v1beta1, with v1beta1 replaced by v1.
The interoperability support is the same that was used for v1alpha4.
Adding it "reverts" the removal of the v1alpha4 support in
a57f15e, except that now v1beta1 is the legacy
API which needs conversion. If kubelet and the plugin both support v1, no
conversion is needed.
@pohly pohly force-pushed the dra-kubelet-grpc-v1 branch from 4241e4c to 29828c1 Compare July 4, 2025 09:20
@pohly
Copy link
Contributor Author

pohly commented Jul 4, 2025

/assign @bart0sh

CI is green now.

pohly added a commit to pohly/kubernetes that referenced this pull request Jul 4, 2025
@pohly
merge kubernetes#132700 dra-kubelet-grpc-v1
4b89fe3
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bart0sh bart0sh Awaiting requested review from bart0sh

@haircommander haircommander Awaiting requested review from haircommander

Assignees

@bart0sh bart0sh

Labels
area/kubelet area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/deprecation Categorizes issue or PR as related to a feature/enhancement marked for deprecation. kind/feature Categorizes issue or PR as related to a new feature. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/node Categorizes an issue or PR as relevant to SIG Node. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/XXL Denotes a PR that changes 1000+ lines, ignoring generated files. wg/device-management Categorizes an issue or PR as relevant to WG Device Management.
Projects
Dynamic Resource Allocation
Status: 🆕 New
SIG Node CI/Test Board
Status: Archive-it
SIG Node: code and documentation PRs
Status: Triage
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@pohly @k8s-ci-robot @bart0sh

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.