deflake storage tests: changing the name of non-namespaced items like ClusterRole with driver namespace as suffix by carlory · Pull Request #132695 · kubernetes/kubernetes · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

deflake storage tests: changing the name of non-namespaced items like ClusterRole with driver namespace as suffix #132695

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

deflake storage tests: changing the name of non-namespaced items like ClusterRole with driver namespace as suffix #132695

wants to merge 1 commit into from
+24 −10

Conversation

carlory
Copy link
Member

@carlory carlory commented Jul 3, 2025 •
edited
Loading

What type of PR is this?

What this PR does / why we need it:

#129369 want to fix #118037 but it cause another flaky test when the test has a bad cleanup

so we can not remove the driver namespace before test namespace.

we need to change the generation policy of all non-namespaced resource for driver manifests.

Which issue(s) this PR is related to:

Special notes for your reviewer:

Does this PR introduce a user-facing change?

NONE

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@k8s-ci-robot k8s-ci-robot added release-note-none Denotes a PR that doesn't merit a release note. size/M Denotes a PR that changes 30-99 lines, ignoring generated files. cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Jul 3, 2025
@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added needs-priority Indicates a PR lacks a `priority/foo` label and requires one. area/test sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. and removed do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. labels Jul 3, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: carlory

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Jul 3, 2025
@k8s-ci-robot k8s-ci-robot requested review from pohly and xing-yang July 3, 2025 03:49
@carlory
Copy link
Member Author

carlory commented Jul 3, 2025

/cc @gnufied @jsafrane

@k8s-ci-robot k8s-ci-robot requested review from gnufied and jsafrane July 3, 2025 03:50
@carlory
Copy link
Member Author

carlory commented Jul 3, 2025

/hold
for review.

@k8s-ci-robot k8s-ci-robot added the do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. label Jul 3, 2025
@carlory
Copy link
Member Author

carlory commented Jul 3, 2025

/test pull-kubernetes-unit

@carlory
Copy link
Member Author

carlory commented Jul 3, 2025

/kind failing-test

@k8s-ci-robot k8s-ci-robot added kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. and removed do-not-merge/needs-kind Indicates a PR lacks a `kind/foo` label and requires one. labels Jul 3, 2025
@lmktfy
Copy link

lmktfy commented Jul 4, 2025

We try to avoid referencing PRs in commit messages. Is the PR title right? (I would edit it)

@lmktfy
Copy link

lmktfy commented Jul 4, 2025

BTW, when Prow triggers a merge, the title of a PR becomes part of a commit message.

@pohly
Copy link
Contributor

pohly commented Jul 4, 2025

We try to avoid referencing PRs in commit messages. Is the PR title right? (I would edit it)

Do we have that policy documented somewhere, including the rationale?

Does the same apply to commit hashes?

@lmktfy
Copy link

lmktfy commented Jul 4, 2025

https://www.kubernetes.dev/docs/guide/pull-requests/#do-not-use-github-keywords-or-mentions-within-your-commit-message

@carlory
storage e2e test: Changing the name of non-namespaced items like Clus…
0f6dbc9 
…terRole with driver namespace as suffix before create it

Signed-off-by: carlory <baofa.fan@daocloud.io>
@carlory carlory changed the title Revert #129369 and changing the name of non-namespaced items like ClusterRole with driver namespace as suffix deflake storage tests: changing the name of non-namespaced items like ClusterRole with driver namespace as suffix Jul 4, 2025
@carlory
Copy link
Member Author

carlory commented Jul 4, 2025

We try to avoid referencing PRs in commit messages. Is the PR title right? (I would edit it)

I changed it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pohly pohly Awaiting requested review from pohly

@xing-yang xing-yang Awaiting requested review from xing-yang

@gnufied gnufied Awaiting requested review from gnufied

@jsafrane jsafrane Awaiting requested review from jsafrane

Assignees
No one assigned
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. area/test cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/hold Indicates that a PR should not merge because someone has issued a /hold command. kind/failing-test Categorizes issue or PR as related to a consistently or frequently failing test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note-none Denotes a PR that doesn't merit a release note. sig/storage Categorizes an issue or PR as relevant to SIG Storage. sig/testing Categorizes an issue or PR as relevant to SIG Testing. size/M Denotes a PR that changes 30-99 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
4 participants
@carlory @k8s-ci-robot @lmktfy @pohly

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.