Skip validation for unsupported aggregated pod-level resource requests by HoKim98 · Pull Request #131262 · kubernetes/kubernetes · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

Skip validation for unsupported aggregated pod-level resource requests #131262

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

Skip validation for unsupported aggregated pod-level resource requests #131262

wants to merge 1 commit into from
+6 −0

Conversation

HoKim98
Copy link

@HoKim98 HoKim98 commented Apr 11, 2025 •
edited
Loading

What type of PR is this?

/kind bug

What this PR does / why we need it:

Which issue(s) this PR fixes:

Fixes #132449

Special notes for your reviewer:

The pod-level resource map only supports cpu and memory.
So, the other external resources (e.g. example.com/gpu) is not supported.

But, when validating Pod-level requests must be >= aggregate requests of all containers in a pod, the validator tests example.com/gpu and returns error must be greater than or equal to aggregate container requests of %s.

For example, the official example works like:

apiVersion: v1
kind: Pod
metadata:
  name: pod-resources-demo
  namespace: pod-resources-example
spec:
  resources:
    limits:
      cpu: "1"
      memory: "200Mi"
    requests:
      cpu: "1"
      memory: "100Mi"
  containers:
  - name: pod-resources-demo-ctr-1
    image: nginx
    resources:
      limits:
        cpu: "0.5"
        memory: "100Mi"
      requests:
        cpu: "0.5"
        memory: "50Mi"
  - name: pod-resources-demo-ctr-2
    image: fedora
    command:
    - sleep
    - inf

However, when we want to use external resources in the container, the problem occurs.

apiVersion: v1
kind: Pod
metadata:
  name: pod-resources-demo-with-gpu
  namespace: pod-resources-example
spec:
  resources:
    limits:
      cpu: "1"
      memory: "200Mi"
    requests:
      cpu: "1"
      memory: "100Mi"
  containers:
  - name: pod-resources-demo-ctr-1
    image: nginx
    resources:
      limits:
        cpu: "0.5"
        memory: "100Mi"
        example.com/gpu: "1" # ERROR!
      requests:
        cpu: "0.5"
        memory: "50Mi"
  - name: pod-resources-demo-ctr-2
    image: fedora
    command:
    - sleep
    - inf

To use these external resources with pod-level resources, the pod-level resource validator should ignore these unsupported resources.

Does this PR introduce a user-facing change?

Fix incorrect pod-level resource validation error when using extended resources (e.g. GPUs) by limiting validation scope to CPU and memory only.

Additional documentation e.g., KEPs (Kubernetes Enhancement Proposals), usage docs, etc.:

@HoKim98
fix: skip-validation-for-unsupported-aggregated-pod-level-resource-re…
8b4089d 
…quests

Signed-off-by: Ho Kim <ho.kim@ulagbulag.io>
@k8s-ci-robot k8s-ci-robot added do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. release-note Denotes a PR that will be considered when it comes time to generate release notes. kind/bug Categorizes issue or PR as related to a bug. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Apr 11, 2025
@k8s-ci-robot
Copy link
Contributor

Please note that we're already in Test Freeze for the release-1.33 branch. This means every merged PR will be automatically fast-forwarded via the periodic ci-fast-forward job to the release branch of the upcoming v1.33.0 release.

Fast forwards are scheduled to happen every 6 hours, whereas the most recent run was: Fri Apr 11 13:33:04 UTC 2025.

@k8s-ci-robot k8s-ci-robot added cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. labels Apr 11, 2025
@k8s-ci-robot
Copy link
Contributor

Welcome @HoKim98!

It looks like this is your first PR to kubernetes/kubernetes 🎉. Please refer to our pull request process documentation to help your PR have a smooth ride to approval.

You will be prompted by a bot to use commands during the review process. Do not be afraid to follow the prompts! It is okay to experiment. Here is the bot commands documentation.

You can also check if kubernetes/kubernetes has its own contribution guidelines.

You may want to refer to our testing guide if you run into trouble with your tests not passing.

If you are having difficulty getting your pull request seen, please follow the recommended escalation practices. Also, for tips and tricks in the contribution process you may want to read the Kubernetes contributor cheat sheet. We want to make sure your contribution gets all the attention it needs!

Thank you, and welcome to Kubernetes. 😃

@k8s-ci-robot
Copy link
Contributor

This issue is currently awaiting triage.

If a SIG or subproject determines this is a relevant issue, they will accept it by applying the triage/accepted label and provide further guidance.

The triage/accepted label can be added by org members by writing /triage accepted in a comment.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. label Apr 11, 2025
@k8s-ci-robot
Copy link
Contributor

Hi @HoKim98. Thanks for your PR.

I'm waiting for a kubernetes member to verify that this patch is reasonable to test. If it is, they should reply with /ok-to-test on its own line. Until that is done, I will not automatically test new commits in this PR, but the usual testing commands by org members will still work. Regular contributors should join the org to skip this step.

Once the patch is verified, the new status will be reflected by the ok-to-test label.

I understand the commands that are listed here.

Instructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository.

@k8s-ci-robot k8s-ci-robot added the needs-priority Indicates a PR lacks a `priority/foo` label and requires one. label Apr 11, 2025
@HoKim98 HoKim98 marked this pull request as ready for review April 11, 2025 14:58
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/work-in-progress Indicates that a PR should not merge because it is a work in progress. label Apr 11, 2025
@k8s-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is NOT APPROVED

This pull-request has been approved by: HoKim98
Once this PR has been reviewed and has the lgtm label, please assign msau42 for approval. For more information see the Code Review Process.

The full list of commands accepted by this bot can be found here.

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@k8s-ci-robot k8s-ci-robot added the sig/apps Categorizes an issue or PR as relevant to SIG Apps. label Apr 11, 2025
@k8s-ci-robot k8s-ci-robot removed the do-not-merge/needs-sig Indicates an issue or PR lacks a `sig/foo` label and requires one. label Apr 11, 2025
@k8s-ci-robot k8s-ci-robot requested review from sttts and tallclair April 11, 2025 14:58
@github-project-automation github-project-automation bot moved this to Needs Triage in SIG Apps Apr 11, 2025
@HoKim98 HoKim98 changed the title fix: skip-validation-for-unsupported-aggregated-pod-level-resource-requests S kip validation for unsupported aggregated pod-level resource requests Apr 11, 2025
@HoKim98 HoKim98 changed the title S kip validation for unsupported aggregated pod-level resource requests Skip validation for unsupported aggregated pod-level resource requests Apr 11, 2025
@HoKim98 HoKim98 changed the title Skip validation for unsupported aggregated pod-level resource requests Skip validation of unsupported aggregated pod-level resource requests Apr 11, 2025
@HoKim98 HoKim98 changed the title Skip validation of unsupported aggregated pod-level resource requests Skip validation for unsupported aggregated pod-level resource requests Apr 11, 2025
kannon92
kannon92 reviewed Apr 13, 2025
View reviewed changes
pkg/apis/core/validation/validation.go
@@ -4382,8 +4382,14 @@ func validatePodResourceConsistency(spec *core.PodSpec, fldPath *field.Path) fie
// calculation without modifying AggregateContainerRequests method.
aggrContainerReqs := resourcehelper.AggregateContainerRequests(&v1.Pod{Spec: *v1PodSpec}, resourcehelper.PodResourcesOptions{})

supportedResourceNames := resourcehelper.SupportedPodLevelResources()
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice find! Can you add some unit tests for this?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok, I'll add some appropriate unit tests and get back to you!

@toVersus
Copy link
Contributor

I think this PR is a duplicate of #130131.

/sig node
/cc @ndixita

@k8s-ci-robot k8s-ci-robot requested a review from ndixita April 14, 2025 00:19
@k8s-ci-robot k8s-ci-robot added the sig/node Categorizes an issue or PR as relevant to SIG Node. label Apr 14, 2025
@HoKim98
Copy link
Author

HoKim98 commented Apr 14, 2025

Oh I see

@HoKim98 HoKim98 closed this Apr 14, 2025
@github-project-automation github-project-automation bot moved this from Needs Triage to Closed in SIG Apps Apr 14, 2025
@toVersus toVersus mentioned this pull request Apr 14, 2025
Open
@toVersus toVersus mentioned this pull request Jun 24, 2025
Open
@HoKim98 HoKim98 reopened this Jul 4, 2025
@HoKim98
Copy link
Author

HoKim98 commented Jul 4, 2025

Reopened the PR to fix #132449

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kannon92 kannon92 kannon92 left review comments

@justinsb justinsb Awaiting requested review from justinsb

@yujuhong yujuhong Awaiting requested review from yujuhong

@sttts sttts Awaiting requested review from sttts

@tallclair tallclair Awaiting requested review from tallclair

@ndixita ndixita Awaiting requested review from ndixita

Assignees
No one assigned
Labels
cncf-cla: yes Indicates the PR's author has signed the CNCF CLA. kind/bug Categorizes issue or PR as related to a bug. needs-ok-to-test Indicates a PR that requires an org member to verify it is safe to test. needs-priority Indicates a PR lacks a `priority/foo` label and requires one. needs-triage Indicates an issue or PR lacks a `triage/foo` label and requires one. release-note Denotes a PR that will be considered when it comes time to generate release notes. sig/apps Categorizes an issue or PR as relevant to SIG Apps. sig/node Categorizes an issue or PR as relevant to SIG Node. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
SIG Apps
Archived in project
SIG Node: code and documentation PRs
Archived in project
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Pod Level Resources] Pod-level resource validation fails when container-level is set for other resource
4 participants
@HoKim98 @k8s-ci-robot @toVersus @kannon92

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.