isHexColor.js #1973
Open
isHexColor.js #1973
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In this additional file we check is input value is hex formate color
Arkni
requested changes
Jun 18, 2018
There was a problem hiding this comment.
Hi @miladganjali,
I'm really sorry for taking so long to review your PR. We were overwhelmed with the increasing number of issues and PR.
I have left some comments I would like addressed before merging.
Also, do you think you can add some tests for this method?
If so, you can create a file under test/additional/ and import it in test/index.html.
Thanks for your contribution :)
| @@ -0,0 +1,3 @@ | |||
| $.validator.addMethod( "ishexcolor", function( value, element ) { | |||
There was a problem hiding this comment.
Can you change the name to hexcolor in order to be consistent with other additional methods?
Also, I would like the file to be renamed to hexcolor as well.
| @@ -0,0 +1,3 @@ | |||
| $.validator.addMethod( "ishexcolor", function( value, element ) { | |||
| return this.optional( element ) || /^#(?:[0-9a-f]{6}|[0-9a-f]{3})$/i.test( value ); | |||
| }, "This is not hex format color" ); | |||
There was a problem hiding this comment.
Please change this message to something like: Please specify a valid hex color value
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this additional file we check is input value is hex formate color