Properly identify the Authorization header's Realm part. #151
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Good catch; you have a regression test (or an example request I can build one with?). |
|
@joestump love his tests 👍 (so do I) |
|
This is a great fix. It turns out that if (for example) the @erikvanzijst I created the test for this on erikvanzijst#2. After you review and merge I think this is good to go. |
|
Thanks @rickhanlonii you're a boss! |
|
I pulled this PR into a new fork: https://github.com/TimSC/python-oauth10a |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This broke authentication whenever any of the
oauth_parameters contained the substring "realm" anywhere.