fix: Only send mtlsEndpoint if it is non-null #3767
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
blakeli0
reviewed
Apr 29, 2025
product-auto-label
bot
added
size: m
blakeli0
approved these changes
May 2, 2025
|
|
lqiu96
added a commit
that referenced
this pull request
May 2, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>2.56.3</summary> ## [2.56.3](v2.56.2...v2.56.3) (2025-05-02) ### Bug Fixes * Only send mtlsEndpoint if it is non-null ([#3767](#3767)) ([8f8df7b](8f8df7b)) * subscribe Airlock Docker image definition to GRPC updates ([#3765](#3765)) ([d0f43e3](d0f43e3)) ### Dependencies * update dependency com.google.errorprone:error_prone_annotations to v2.38.0 ([#3773](#3773)) ([e16fe65](e16fe65)) * update gapic-showcase to 36.2 ([#3771](#3771)) ([15b2577](15b2577)) * update google auth library dependencies to v1.34.0 ([#3772](#3772)) ([406a180](406a180)) * Update maven-shared-utils to v3.2.1 ([#3768](#3768)) ([7ec93c3](7ec93c3)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Lawrence Qiu <lawrenceqiu@google.com>
lqiu96
added a commit
that referenced
this pull request
Jun 10, 2025
Temporary fix to only plumb the mtlsEndpoint to the gRPCChannelProviders if this has been set with a non-null value. Validation will still go through if it is set with bogus values. Issue reported in googleapis/java-bigtable#2565 This seems to due to how Bigtable wrappers the generated stubs. BigTable manually calls setEndpoint to for the StubSettings, but does not do the equivalent for setMtlsEndpoint. The EndpointContext is only aware of the TLS endpoint and passes a null value to the ChannelProviders. Potential longer term fix: BigTable's wrappers would need to set the mTLS Endpoint. This would be needed for BigTable to support S2A. This does not impact any of BigTable's existing functionality as the endpoint resolution for all non-S2A flows is done via `setEndpoint()`.
lqiu96
added a commit
that referenced
this pull request
Jun 10, 2025
🤖 I have created a release *beep* *boop* --- <details><summary>2.56.3</summary> ## [2.56.3](v2.56.2...v2.56.3) (2025-05-02) ### Bug Fixes * Only send mtlsEndpoint if it is non-null ([#3767](#3767)) ([8f8df7b](8f8df7b)) * subscribe Airlock Docker image definition to GRPC updates ([#3765](#3765)) ([d0f43e3](d0f43e3)) ### Dependencies * update dependency com.google.errorprone:error_prone_annotations to v2.38.0 ([#3773](#3773)) ([e16fe65](e16fe65)) * update gapic-showcase to 36.2 ([#3771](#3771)) ([15b2577](15b2577)) * update google auth library dependencies to v1.34.0 ([#3772](#3772)) ([406a180](406a180)) * Update maven-shared-utils to v3.2.1 ([#3768](#3768)) ([7ec93c3](7ec93c3)) </details> --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please). --------- Co-authored-by: release-please[bot] <55107282+release-please[bot]@users.noreply.github.com> Co-authored-by: Lawrence Qiu <lawrenceqiu@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Temporary fix to only plumb the mtlsEndpoint to the gRPCChannelProviders if this has been set with a non-null value. Validation will still go through if it is set with bogus values.
Issue reported in googleapis/java-bigtable#2565
This seems to due to how Bigtable wrappers the generated stubs. BigTable manually calls setEndpoint to for the StubSettings, but does not do the equivalent for setMtlsEndpoint. The EndpointContext is only aware of the TLS endpoint and passes a null value to the ChannelProviders.
Potential longer term fix: BigTable's wrappers would need to set the mTLS Endpoint. This would be needed for BigTable to support S2A. This does not impact any of BigTable's existing functionality as the endpoint resolution for all non-S2A flows is done via
setEndpoint().