chore: edition sample fix with increased timeout #1339
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sri Harsha CH <sriharshach@google.com>
product-auto-label
bot
added
size: xs
harshachinta
commented
Apr 22, 2025
| ), | ||
| field_mask=field_mask_pb2.FieldMask(paths=["labels", "edition"]), | ||
| ) | ||
|
|
||
| print("Waiting for operation to complete...") | ||
| operation.result(OPERATION_TIMEOUT_SECONDS) | ||
| operation.result(900) |
There was a problem hiding this comment.
With the current timeout of 240 seconds, the sample is failing. When we increase it to 900 seconds it works.
Raised the issue to the editions team. Meanwhile to unblock PR merges and prevent samples failure this PR will help.
There was a problem hiding this comment.
Confirmed with editions team that is expected behaviour.
Yes, this is expected. Previously we weren't waiting for galaxy and spanfe caches to be populated with the modified edition. Now we are. This takes approximately 10 min.
harshachinta
requested review from
rahul2393,
sakthivelmanii and
surbhigarg92
and removed request for
balajismaniam
sakthivelmanii
approved these changes
Apr 22, 2025
harshachinta
commented
Apr 22, 2025
| @@ -91,13 +91,13 @@ def update_instance(instance_id): | |||
| labels={ | |||
| "sample_name": "snippets-update_instance-explicit", | |||
| }, | |||
| edition=spanner_instance_admin.Instance.Edition.STANDARD, # Optional | |||
| edition=spanner_instance_admin.Instance.Edition.ENTERPRISE, # Optional | |||
There was a problem hiding this comment.
In order to merge split API sample I had to change this to STANDARD in that PR so that the tests pass.
Reverting back that change in this PR.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.