chore: add owlbot rule to preserve app_profile_id header by daniel-sanche · Pull Request #1115 · googleapis/python-bigtable · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

chore: add owlbot rule to preserve app_profile_id header #1115

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 12 commits into from
May 16, 2025

Conversation

daniel-sanche
Copy link
Contributor

@daniel-sanche daniel-sanche commented Apr 26, 2025

We've previously added temporary changes to attach empty string app_profile_id routing headers. This PR makes a change to owlbot.py to ensure the change persists between gapic changes

This is only strictly needed for execute_query and prepare_query, but for simplicity I made the change across all rpcs

Long term, the backend should change, since empty string routing headers is out of spec

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/python-bigtable API. labels Apr 26, 2025
@daniel-sanche daniel-sanche added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 26, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 26, 2025
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Apr 26, 2025
@daniel-sanche daniel-sanche force-pushed the patch_app_profile_header branch from 00e8c80 to a7e2110 Compare April 26, 2025 00:17
@daniel-sanche daniel-sanche added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 26, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 26, 2025
@daniel-sanche daniel-sanche force-pushed the patch_app_profile_header branch from 7995202 to ab69446 Compare April 26, 2025 00:30
@daniel-sanche daniel-sanche added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 26, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 26, 2025
@daniel-sanche daniel-sanche added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 28, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 28, 2025
@daniel-sanche daniel-sanche force-pushed the patch_app_profile_header branch from 2709b0a to e301c92 Compare April 28, 2025 16:36
@daniel-sanche daniel-sanche added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 28, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 28, 2025
@daniel-sanche daniel-sanche force-pushed the patch_app_profile_header branch from eb8b2c2 to cf59221 Compare April 28, 2025 17:00
@daniel-sanche daniel-sanche added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 28, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 28, 2025
@daniel-sanche daniel-sanche added the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 28, 2025
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 28, 2025
@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 29, 2025
@daniel-sanche daniel-sanche marked this pull request as ready for review April 29, 2025 22:01
@daniel-sanche daniel-sanche requested review from a team as code owners April 29, 2025 22:01
@daniel-sanche daniel-sanche changed the title [DRAFT] chore: add owlbot rule to preserve app_profile_id header chore: add owlbot rule to preserve app_profile_id header Apr 29, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 29, 2025
@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 30, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 30, 2025
@daniel-sanche daniel-sanche added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 1, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label May 1, 2025
@daniel-sanche daniel-sanche merged commit 22bb400 into main May 16, 2025
16 checks passed
@daniel-sanche daniel-sanche deleted the patch_app_profile_header branch May 16, 2025 22:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the googleapis/python-bigtable API. size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.