-
Notifications
You must be signed in to change notification settings - Fork 318
feat: job creation mode GA #2190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
d36dbf4
edee9dd
698fdbb
5cd1b07
5a0a69d
b300fb4
289a933
7043686
de69890
dca7be6
28b69cf
afa142c
4ab55c6
ca36518
1a9df99
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,4 +1,4 @@ | ||
# Copyright 2024 Google LLC | ||
# Copyright 2025 Google LLC | ||
# | ||
# Licensed under the Apache License, Version 2.0 (the "License"); | ||
# you may not use this file except in compliance with the License. | ||
|
@@ -14,13 +14,13 @@ | |
|
||
import typing | ||
|
||
from .. import client_query_shortmode | ||
from .. import client_query_job_optional | ||
|
||
if typing.TYPE_CHECKING: | ||
import pytest | ||
|
||
|
||
def test_client_query_shortmode(capsys: "pytest.CaptureFixture[str]") -> None: | ||
client_query_shortmode.client_query_shortmode() | ||
client_query_job_optional.client_query_job_optional() | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Should we add some verification that the query was indeed run in jobless mode? There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Control over execution is still the responsible of the service, and it can choose to fallback to using jobs regardless of the requested mode. |
||
out, err = capsys.readouterr() | ||
assert "Query was run" in out |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Any chance we could check for the environment variable for a bit here? Maybe with a warning to set it as a client option instead in the future?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Chatted offline. I'll aim to get bigframes 1.x and 2.x releases out to support this change before the client library release to minimize disruption.