ci: Import numpy before pyarrow in tests to resolve import warning #2187
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A `PytestDeprecationWarning` was occurring in several test files
because `pyarrow`, when imported by `pytest.importorskip`, would fail
to import `numpy.core.multiarray`.
This change addresses the warning by explicitly importing `numpy`
before `pytest.importorskip("pyarrow", ...)` in the affected
test files. This ensures that numpy is fully initialized before
pyarrow attempts to use it, resolving the underlying import error.
I also updated the test execution to use `nox -s unit`, which
correctly sets up the test environment and dependencies, allowing
the tests to pass and confirm the warning is resolved. Pre-existing
failures in `tests/unit/test_magics.py` are unrelated to this change.
product-auto-label
bot
added
size: s
chalmerlowe
commented
May 15, 2025
chalmerlowe
commented
May 19, 2025
tswast
approved these changes
May 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A
PytestDeprecationWarningwas occurring in several test files becausepyarrow, when imported bypytest.importorskip, would fail to importnumpy.core.multiarray.This change addresses the warning by explicitly importing
numpybeforepytest.importorskip("pyarrow", ...)in the affected test files. This ensures that numpy is fully initialized before pyarrow attempts to use it, resolving the underlying import error.