ci: allow nonexistent profile in google-cloud-bigtable by suztomo · Pull Request #2611 · googleapis/java-bigtable · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

ci: allow nonexistent profile in google-cloud-bigtable #2611

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 3 commits into from
Jun 23, 2025
Merged

ci: allow nonexistent profile in google-cloud-bigtable #2611

merged 3 commits into from
Jun 23, 2025

Conversation

suztomo
Copy link
Member

@suztomo suztomo commented Jun 23, 2025 •
edited
Loading

Our new release job script specifies profiles that might not exist in all Java projects in our release pipeline. The requireProfileIdsExist enforcer rule fails in that case.

[ERROR] Failed to execute goal org.apache.maven.plugins:maven-enforcer-plugin:3.5.0:enforce (enforce-valid-profile) on project google-cloud-bigtable: 
[ERROR] Rule 0: org.apache.maven.enforcer.rules.RequireProfileIdsExist failed with message:
[ERROR] The requested profile doesn't exist: release-staging-repository

Therefore, let's disable the requireProfileIdsExist rule during the release. This change created a profile that does that:

    <profile>
      <id>enable-enforcer-rules</id>
      <activation>
        <property>
          <!-- By default, Maven runs the enforcer rules. The shared release script
            may pass profile name that doesn't exist in this project. Let's ignore
            the enforcer rule (requireProfileIdsExist) in that case, leveraging
            the presence of the performRelease property. -->
          <name>!performRelease</name>
        </property>
...

@suztomo
ci: allow nonexistent profile in google-cloud-bigtable
ce6f467 
Our release job specifies profiles that may or may not exist in
all Java projects in our release pipeline. The
requireProfileIdsExist enforcer rule fails in that case.

Therefore, let's remove the requireProfileIdsExist rule.
@suztomo suztomo requested review from a team as code owners June 23, 2025 01:33
@product-auto-label product-auto-label bot added size: s Pull request size is small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Jun 23, 2025
mpeddada1
mpeddada1 previously approved these changes Jun 23, 2025
View reviewed changes
@suztomo
Copy link
Member Author

suztomo commented Jun 23, 2025

Somehow the bot added a commit 4efc30b that touches Java code. Now it requires api-bigtable team's review.

@mutianf
Copy link
Contributor

mutianf commented Jun 23, 2025

I'm a little concerned about removing this check. This is to prevent false positives when someone mistyped a profile name. Are there alternatives?

@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: s Pull request size is small. labels Jun 23, 2025
@suztomo
Copy link
Member Author

suztomo commented Jun 23, 2025

@mutianf Updated it to use a profile that's activated by default. PTAL.

@mutianf mutianf added the automerge Merge the pull request once unit tests and other checks pass. label Jun 23, 2025
@gcf-merge-on-green gcf-merge-on-green bot merged commit 3424cb5 into main Jun 23, 2025
36 of 37 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Jun 23, 2025
@gcf-merge-on-green gcf-merge-on-green bot deleted the profile_flexibility branch June 23, 2025 15:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mutianf mutianf mutianf approved these changes

@mpeddada1 mpeddada1 mpeddada1 left review comments

@igorbernstein2 igorbernstein2 Awaiting requested review from igorbernstein2

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@suztomo @mutianf @mpeddada1 @cloud-java-bot

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.