chore: mark opencensus as deprecated by andre-sampaio · Pull Request #2533 · googleapis/java-bigtable · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

chore: mark opencensus as deprecated #2533

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Apr 24, 2025
Merged

chore: mark opencensus as deprecated #2533

merged 5 commits into from
Apr 24, 2025

Conversation

andre-sampaio
Copy link
Contributor

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

@andre-sampaio andre-sampaio requested review from a team as code owners March 19, 2025 15:07
@product-auto-label product-auto-label bot added size: m Pull request size is medium. api: bigtable Issues related to the googleapis/java-bigtable API. labels Mar 19, 2025
@andre-sampaio andre-sampaio added the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 20, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 20, 2025
igorbernstein2
igorbernstein2 reviewed Mar 20, 2025
View reviewed changes
Copy link
Contributor

@igorbernstein2 igorbernstein2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think you need to annotate RpcViews as well

@andre-sampaio andre-sampaio force-pushed the opencensus-deprecation branch from 9a29bfe to a4a1bf4 Compare March 24, 2025 19:16
@andre-sampaio andre-sampaio added the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 24, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Mar 24, 2025
@andre-sampaio andre-sampaio force-pushed the opencensus-deprecation branch from f143b85 to 80b0a28 Compare March 24, 2025 19:58
@product-auto-label product-auto-label bot added size: l Pull request size is large. and removed size: m Pull request size is medium. labels Apr 24, 2025
@generated-files-bot Generated Files Bot
Copy link

Warning: This pull request is touching the following templated files:

  • samples/snapshot/pom.xml

@andre-sampaio andre-sampaio force-pushed the opencensus-deprecation branch from debd871 to aa9d253 Compare April 24, 2025 14:39
@product-auto-label product-auto-label bot added size: m Pull request size is medium. and removed size: l Pull request size is large. labels Apr 24, 2025
@andre-sampaio andre-sampaio added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 24, 2025
@andre-sampaio
Copy link
Contributor Author

I think you need to annotate RpcViews as well

Done

mutianf
mutianf reviewed Apr 24, 2025
View reviewed changes
README.md Outdated
@@ -247,122 +247,6 @@ your OpenTelemetry instance. You can refer to
[CustomOpenTelemetryMetricsProvider](https://github.com/googleapis/java-bigtable/blob/main/google-cloud-bigtable/src/main/java/com/google/cloud/bigtable/data/v2/stub/metrics/CustomOpenTelemetryMetricsProvider.java)
on how to set it up.

## Client request tracing: OpenCensus Tracing
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you need to update the .readme-partials.yml file instead for changes in README

@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 24, 2025
@andre-sampaio andre-sampaio added automerge Merge the pull request once unit tests and other checks pass. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Apr 24, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Apr 24, 2025
@andre-sampaio andre-sampaio force-pushed the opencensus-deprecation branch from c2a9303 to 5d7534b Compare April 24, 2025 21:30
@andre-sampaio andre-sampaio added the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 24, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Apr 24, 2025
@gcf-merge-on-green gcf-merge-on-green bot merged commit 832e8dc into googleapis:main Apr 24, 2025
22 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@igorbernstein2 igorbernstein2 igorbernstein2 left review comments

@mutianf mutianf mutianf approved these changes

Assignees
No one assigned
Labels
api: bigtable Issues related to the googleapis/java-bigtable API. size: m Pull request size is medium.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@andre-sampaio @mutianf @igorbernstein2 @yoshi-kokoro

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.