feat(spanner): add support for order_by enum by mpeddada1 · Pull Request #15240 · googleapis/google-cloud-cpp · GitHub | Latest TMZ Celebrity News & Gossip | Watch TMZ Live
Skip to content

feat(spanner): add support for order_by enum #15240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 6 commits into
base: main
Choose a base branch
from
Open

feat(spanner): add support for order_by enum #15240

wants to merge 6 commits into from

Conversation

mpeddada1
Copy link

@mpeddada1 mpeddada1 commented Jun 30, 2025 •
edited
Loading

This change is Reviewable

This PR does the following:

  • Implements the OrderBy enum.
  • Implements Option type for the enum.
  • Allows it to be set via ReadParams in conn->Read.

Emulates the setup in #6103

@product-auto-label product-auto-label bot added the api: spanner Issues related to the Spanner API. label Jun 30, 2025
@codecov Codecov
Copy link

codecov bot commented Jun 30, 2025 •
edited
Loading

Codecov Report

Attention: Patch coverage is 98.13084% with 2 lines in your changes missing coverage. Please review.

Project coverage is 92.93%. Comparing base (8727ff0) to head (94472f6).

Files with missing lines Patch % Lines
google/cloud/spanner/internal/connection_impl.cc 90.90% 1 Missing ⚠️
...gle/cloud/spanner/internal/connection_impl_test.cc 97.91% 1 Missing ⚠️
Additional details and impacted files 
@@            Coverage Diff             @@
##             main   #15240      +/-   ##
==========================================
- Coverage   92.93%   92.93%   -0.01%     
==========================================
  Files        2394     2394              
  Lines      215352   215448      +96     
==========================================
+ Hits       200142   200225      +83     
- Misses      15210    15223      +13

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@mpeddada1 mpeddada1 marked this pull request as ready for review June 30, 2025 19:35
@mpeddada1 mpeddada1 requested a review from a team as a code owner June 30, 2025 19:35
@mpeddada1 mpeddada1 requested a review from scotthart June 30, 2025 19:53
@mpeddada1 mpeddada1 mentioned this pull request Jul 1, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@scotthart scotthart Awaiting requested review from scotthart

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
api: spanner Issues related to the Spanner API.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@mpeddada1

TMZ Celebrity News – Breaking Stories, Videos & Gossip

Looking for the latest TMZ celebrity news? You've come to the right place. From shocking Hollywood scandals to exclusive videos, TMZ delivers it all in real time.

Whether it’s a red carpet slip-up, a viral paparazzi moment, or a legal drama involving your favorite stars, TMZ news is always first to break the story. Stay in the loop with daily updates, insider tips, and jaw-dropping photos.

🎥 Watch TMZ Live

TMZ Live brings you daily celebrity news and interviews straight from the TMZ newsroom. Don’t miss a beat—watch now and see what’s trending in Hollywood.